You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/08 09:58:14 UTC
[GitHub] [inlong] LvJiancheng opened a new pull request, #5407: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match
LvJiancheng opened a new pull request, #5407:
URL: https://github.com/apache/inlong/pull/5407
… SinkField fields do not match
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5401
### Motivation
*Fix StreamSinkFieldEntity and SinkField fields not match *
### Modifications
*Fix StreamSinkFieldEntity and SinkField fields not match *
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5407: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5407:
URL: https://github.com/apache/inlong/pull/5407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5407: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5407:
URL: https://github.com/apache/inlong/pull/5407#discussion_r940817095
##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkFieldEntityMapper.xml:
##########
@@ -37,10 +37,13 @@
<result column="field_format" jdbcType="VARCHAR" property="fieldFormat"/>
<result column="rank_num" jdbcType="SMALLINT" property="rankNum"/>
<result column="is_deleted" jdbcType="INTEGER" property="isDeleted"/>
+ <result column="origin_node_name" jdbcType="VARCHAR" property="originNodeName"/>
Review Comment:
Suggests moving those two fields after the `field_format` field, because the `is_deleted` field was a unified field of each table, it should be at the end of each table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] LvJiancheng commented on a diff in pull request #5407: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match
Posted by GitBox <gi...@apache.org>.
LvJiancheng commented on code in PR #5407:
URL: https://github.com/apache/inlong/pull/5407#discussion_r940860825
##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkFieldEntityMapper.xml:
##########
@@ -37,10 +37,13 @@
<result column="field_format" jdbcType="VARCHAR" property="fieldFormat"/>
<result column="rank_num" jdbcType="SMALLINT" property="rankNum"/>
<result column="is_deleted" jdbcType="INTEGER" property="isDeleted"/>
+ <result column="origin_node_name" jdbcType="VARCHAR" property="originNodeName"/>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org