[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #238: HDDS-2588. Consolidate compose environments

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #238: HDDS-2588. Consolidate compose environments
URL: https://github.com/apache/hadoop-ozone/pull/238#discussion_r353179680
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/compose/ozone/run.sh
 ##########
 @@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+declare -ix OZONE_REPLICATION_FACTOR
+: ${OZONE_REPLICATION_FACTOR:=1}
+docker-compose up --scale datanode=${OZONE_REPLICATION_FACTOR} --no-recreate "$@"
 
 Review comment:
   Without `--no-recreate`, if I run `docker-compose up` a second time to start Freon after cluster is up, Docker Compose may recreate all existing containers.  I noticed that this happens when running the second command from another terminal, while following logs in the original terminal.  Not sure if this is really the cause, or what other conditions could trigger it.  Using the flag helps avoid this situation.
   
   Do you think it may cause problems in other cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org