You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/04 20:51:45 UTC
[GitHub] [cassandra] alex-ninja opened a new pull request #951: CASSANDRA-16404. Added a benchmark for checksum calculation.
alex-ninja opened a new pull request #951:
URL: https://github.com/apache/cassandra/pull/951
References: https://issues.apache.org/jira/browse/CASSANDRA-16360
### Context
There is an open discussion in the corresponding ticket, but I feel such a benchmark would be helpful for further development and changes in checksum calculation logic. So regardless the discussion, in the ticket I believe this change is independent enough and can be merged separately.
### Summary of the changes
* Added `ChecksumBench` for benachmarking of checksum calculation
* Fixed formatting in other benchmarks classes
* Fixed `build-jmh` target in `build.xml`
### Open questions
1. Currently there are two benchmarks commented, but that's done for a purpose with a corresponding comment. I feel it is better to have them commented than every time to recover them. Please, let me know your thoughts on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] alex-ninja closed pull request #951: CASSANDRA-16645. Added a benchmark for checksum calculation.
Posted by GitBox <gi...@apache.org>.
alex-ninja closed pull request #951:
URL: https://github.com/apache/cassandra/pull/951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] alex-ninja commented on pull request #951: CASSANDRA-16645. Added a benchmark for checksum calculation.
Posted by GitBox <gi...@apache.org>.
alex-ninja commented on pull request #951:
URL: https://github.com/apache/cassandra/pull/951#issuecomment-830233973
Committed as https://github.com/apache/cassandra/commit/438a9c835abefac18dea8b6fbb422d75ac1b2b15. Closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org