You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/02 10:16:30 UTC
[GitHub] [incubator-doris] dataroaring opened a new pull request #8299: Window funnel
dataroaring opened a new pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299
# Proposed changes
Implement window_funnel aggregate function.
Issue Number: close #xxx
## Problem Summary:
It can be used like window_funnel(window)(timestamp, event1, event2, ..., eventN)
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
Document will be added later.
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] dataroaring commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
dataroaring commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r820073359
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/logging.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/io/var_int.h"
+
+namespace doris::vectorized {
+
+struct WindowFunnelState {
+ std::vector<std::pair<VecDateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void reset() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ std::vector<std::pair<VecDateTimeValue, int>> tmp;
+ events.swap(tmp);
+ }
+
+ void add(const VecDateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
+ }
+
+ int get() const {
+ std::vector<std::optional<VecDateTimeValue>> events_timestamp(max_event_level);
+ for (int64_t i = 0; i < events.size(); i++) {
+ const int& event_idx = events[i].second;
+ const VecDateTimeValue& timestamp = events[i].first;
+ if (event_idx == 0) {
+ events_timestamp[0] = timestamp;
+ continue;
+ }
+ if (events_timestamp[event_idx - 1].has_value()) {
+ const VecDateTimeValue& first_timestamp = events_timestamp[event_idx - 1].value();
+ VecDateTimeValue last_timestamp = first_timestamp;
+ TimeInterval interval(SECOND, window, false);
+ last_timestamp.date_add_interval(interval, SECOND);
+
+ if (timestamp <= last_timestamp) {
+ events_timestamp[event_idx] = first_timestamp;
+ if (event_idx + 1 == max_event_level) {
+ // Usually, max event level is small.
+ return max_event_level;
+ }
+ }
+ }
+ }
+
+ for (int64_t i = events_timestamp.size() - 1; i >= 0; i--) {
+ if (events_timestamp[i].has_value()) {
+ return i + 1;
+ }
+ }
+
+ return 0;
+ }
+
+ void merge(const WindowFunnelState& other) {
+ if (other.events.empty()) {
+ return;
+ }
+
+ int64_t orig_size = events.size();
+ events.insert(std::end(events), std::begin(other.events), std::end(other.events));
+ const auto begin = std::begin(events);
+ const auto middle = std::next(events.begin(), orig_size);
+ const auto end = std::end(events);
+ if (!other.sorted) {
+ std::stable_sort(middle, end);
+ }
+
+ if (!sorted) {
+ std::stable_sort(begin, middle);
+ }
+ std::inplace_merge(begin, middle, end);
+ max_event_level = max_event_level > 0 ? max_event_level : other.max_event_level;
+ window = window > 0 ? window : other.window;
+
+ sorted = true;
+ }
+
+ void write(BufferWritable &out) const {
+ write_var_int(max_event_level, out);
+ write_var_int(window, out);
+ write_var_int(events.size(), out);
+
+ for (int64_t i = 0; i < events.size(); i++) {
+ int64_t timestamp = events[i].first;
+ int event_idx = events[i].second;
+ write_var_int(timestamp, out);
+ write_var_int(event_idx, out);
+ }
+ }
+
+ void read(BufferReadable& in) {
+ int64_t event_level;
+ read_var_int(event_level, in);
+ max_event_level = (int)event_level;
+ read_var_int(window, in);
+ int64_t size = 0;
+ read_var_int(size, in);
+ for (int64_t i = 0; i < size; i++) {
+ int64_t timestamp;
+ int64_t event_idx;
+
+ read_var_int(timestamp, in);
+ read_var_int(event_idx, in);
+ VecDateTimeValue time_value(timestamp);
+ add(time_value, (int)event_idx, max_event_level, window);
+ }
+ }
+};
+
+class AggregateFunctionWindowFunnel
+ : public IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel> {
+public:
+ AggregateFunctionWindowFunnel(const DataTypes& argument_types_)
+ : IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel>(argument_types_, {}) {
+ }
+
+ String get_name() const override { return "window_funnel"; }
+
+ bool insert_to_null_default() const override { return false; }
Review comment:
I expect window_funnel always return non null value, so i put it in AggregateFunction.NOT_NULLABLE_AGGREGATE_FUNCTION_NAME_SET. Does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818435085
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
From the point of view of function capabilities, single parentheses can meet the needs.
For example, intersect count is currently implemented in this way.
From the perspective of grammar compatibility, it depends on whether you want to follow the consistent syntax style of Doris or cater to CK.
In fact, much of the grammar of CK is not generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] emerkfu commented on pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
emerkfu commented on pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#issuecomment-1077483872
Can window be in milliseconds? If the window is in seconds, events that occur in the same second but different milliseconds may be miscalculated. ClickHouse's windoFunnel has such a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818431531
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
Single bracket cant support `Parametric Aggregate Functions` grammar from ck.
Single bracket cannot represent 2 variable length arguments. But maybe we can use some grammar like `(n,a1,a2...an,m,b1,b2..bm)` to represent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
zhangstar333 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818441952
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/logging.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/io/var_int.h"
+
+namespace doris::vectorized {
+
+struct WindowFunnelState {
+ std::vector<std::pair<VecDateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void reset() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ std::vector<std::pair<VecDateTimeValue, int>> tmp;
+ events.swap(tmp);
+ }
+
+ void add(const VecDateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
+ }
+
+ int get() const {
+ std::vector<std::optional<VecDateTimeValue>> events_timestamp(max_event_level);
+ for (int64_t i = 0; i < events.size(); i++) {
+ const int& event_idx = events[i].second;
+ const VecDateTimeValue& timestamp = events[i].first;
+ if (event_idx == 0) {
+ events_timestamp[0] = timestamp;
+ continue;
+ }
+ if (events_timestamp[event_idx - 1].has_value()) {
+ const VecDateTimeValue& first_timestamp = events_timestamp[event_idx - 1].value();
+ VecDateTimeValue last_timestamp = first_timestamp;
+ TimeInterval interval(SECOND, window, false);
+ last_timestamp.date_add_interval(interval, SECOND);
+
+ if (timestamp <= last_timestamp) {
+ events_timestamp[event_idx] = first_timestamp;
+ if (event_idx + 1 == max_event_level) {
+ // Usually, max event level is small.
+ return max_event_level;
+ }
+ }
+ }
+ }
+
+ for (int64_t i = events_timestamp.size() - 1; i >= 0; i--) {
+ if (events_timestamp[i].has_value()) {
+ return i + 1;
+ }
+ }
+
+ return 0;
+ }
+
+ void merge(const WindowFunnelState& other) {
+ if (other.events.empty()) {
+ return;
+ }
+
+ int64_t orig_size = events.size();
+ events.insert(std::end(events), std::begin(other.events), std::end(other.events));
+ const auto begin = std::begin(events);
+ const auto middle = std::next(events.begin(), orig_size);
+ const auto end = std::end(events);
+ if (!other.sorted) {
+ std::stable_sort(middle, end);
+ }
+
+ if (!sorted) {
+ std::stable_sort(begin, middle);
+ }
+ std::inplace_merge(begin, middle, end);
+ max_event_level = max_event_level > 0 ? max_event_level : other.max_event_level;
+ window = window > 0 ? window : other.window;
+
+ sorted = true;
+ }
+
+ void write(BufferWritable &out) const {
+ write_var_int(max_event_level, out);
+ write_var_int(window, out);
+ write_var_int(events.size(), out);
+
+ for (int64_t i = 0; i < events.size(); i++) {
+ int64_t timestamp = events[i].first;
+ int event_idx = events[i].second;
+ write_var_int(timestamp, out);
+ write_var_int(event_idx, out);
+ }
+ }
+
+ void read(BufferReadable& in) {
+ int64_t event_level;
+ read_var_int(event_level, in);
+ max_event_level = (int)event_level;
+ read_var_int(window, in);
+ int64_t size = 0;
+ read_var_int(size, in);
+ for (int64_t i = 0; i < size; i++) {
+ int64_t timestamp;
+ int64_t event_idx;
+
+ read_var_int(timestamp, in);
+ read_var_int(event_idx, in);
+ VecDateTimeValue time_value(timestamp);
+ add(time_value, (int)event_idx, max_event_level, window);
+ }
+ }
+};
+
+class AggregateFunctionWindowFunnel
+ : public IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel> {
+public:
+ AggregateFunctionWindowFunnel(const DataTypes& argument_types_)
+ : IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel>(argument_types_, {}) {
+ }
+
+ String get_name() const override { return "window_funnel"; }
+
+ bool insert_to_null_default() const override { return false; }
Review comment:
this **return false** means in the process of calculating and get final result, you calculate an illegal value and want to insert null by yourself；
Others if **return true**, it will add null by AggregateFunctionNullBase when input is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818431531
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
Single bracket cant support Parametric Aggregate Functions grammar from ck.
Single bracket cannot represent 2 variable length arguments. But maybe we can use some grammar like (n,a1,a2...an,m,b1,b2..bm) to represent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818301213
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/logging.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/io/var_int.h"
+
+namespace doris::vectorized {
+
+struct WindowFunnelState {
+ std::vector<std::pair<VecDateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void reset() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ std::vector<std::pair<VecDateTimeValue, int>> tmp;
+ events.swap(tmp);
+ }
+
+ void add(const VecDateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
+ }
+
+ int get() const {
+ std::vector<std::optional<VecDateTimeValue>> events_timestamp(max_event_level);
+ for (int64_t i = 0; i < events.size(); i++) {
+ const int& event_idx = events[i].second;
+ const VecDateTimeValue& timestamp = events[i].first;
+ if (event_idx == 0) {
+ events_timestamp[0] = timestamp;
+ continue;
+ }
+ if (events_timestamp[event_idx - 1].has_value()) {
+ const VecDateTimeValue& first_timestamp = events_timestamp[event_idx - 1].value();
+ VecDateTimeValue last_timestamp = first_timestamp;
+ TimeInterval interval(SECOND, window, false);
+ last_timestamp.date_add_interval(interval, SECOND);
+
+ if (timestamp <= last_timestamp) {
+ events_timestamp[event_idx] = first_timestamp;
+ if (event_idx + 1 == max_event_level) {
+ // Usually, max event level is small.
+ return max_event_level;
+ }
+ }
+ }
+ }
+
+ for (int64_t i = events_timestamp.size() - 1; i >= 0; i--) {
+ if (events_timestamp[i].has_value()) {
+ return i + 1;
+ }
+ }
+
+ return 0;
+ }
+
+ void merge(const WindowFunnelState& other) {
+ if (other.events.empty()) {
+ return;
+ }
+
+ int64_t orig_size = events.size();
+ events.insert(std::end(events), std::begin(other.events), std::end(other.events));
+ const auto begin = std::begin(events);
+ const auto middle = std::next(events.begin(), orig_size);
+ const auto end = std::end(events);
+ if (!other.sorted) {
+ std::stable_sort(middle, end);
+ }
+
+ if (!sorted) {
+ std::stable_sort(begin, middle);
+ }
+ std::inplace_merge(begin, middle, end);
+ max_event_level = max_event_level > 0 ? max_event_level : other.max_event_level;
+ window = window > 0 ? window : other.window;
+
+ sorted = true;
+ }
+
+ void write(BufferWritable &out) const {
+ write_var_int(max_event_level, out);
Review comment:
Why not just use `write_binary`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818294081
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
Review comment:
This file maybe should add a declare about like
```
// This file is copied from
// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionWindowFunnel.h
// and modified by Doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818364694
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
I prefer the function grammar "windowFunnel(window, mode, timestamp, cond1, cond2, ..., condN)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] emerkfu edited a comment on pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
emerkfu edited a comment on pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#issuecomment-1077483872
Can timestamp be in milliseconds? If the timestamp is in seconds, events that occur in the same second but different milliseconds may be miscalculated. ClickHouse's windoFunnel has such a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
zhangstar333 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r820330598
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/logging.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/io/var_int.h"
+
+namespace doris::vectorized {
+
+struct WindowFunnelState {
+ std::vector<std::pair<VecDateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void reset() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ std::vector<std::pair<VecDateTimeValue, int>> tmp;
+ events.swap(tmp);
+ }
+
+ void add(const VecDateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
+ }
+
+ int get() const {
+ std::vector<std::optional<VecDateTimeValue>> events_timestamp(max_event_level);
+ for (int64_t i = 0; i < events.size(); i++) {
+ const int& event_idx = events[i].second;
+ const VecDateTimeValue& timestamp = events[i].first;
+ if (event_idx == 0) {
+ events_timestamp[0] = timestamp;
+ continue;
+ }
+ if (events_timestamp[event_idx - 1].has_value()) {
+ const VecDateTimeValue& first_timestamp = events_timestamp[event_idx - 1].value();
+ VecDateTimeValue last_timestamp = first_timestamp;
+ TimeInterval interval(SECOND, window, false);
+ last_timestamp.date_add_interval(interval, SECOND);
+
+ if (timestamp <= last_timestamp) {
+ events_timestamp[event_idx] = first_timestamp;
+ if (event_idx + 1 == max_event_level) {
+ // Usually, max event level is small.
+ return max_event_level;
+ }
+ }
+ }
+ }
+
+ for (int64_t i = events_timestamp.size() - 1; i >= 0; i--) {
+ if (events_timestamp[i].has_value()) {
+ return i + 1;
+ }
+ }
+
+ return 0;
+ }
+
+ void merge(const WindowFunnelState& other) {
+ if (other.events.empty()) {
+ return;
+ }
+
+ int64_t orig_size = events.size();
+ events.insert(std::end(events), std::begin(other.events), std::end(other.events));
+ const auto begin = std::begin(events);
+ const auto middle = std::next(events.begin(), orig_size);
+ const auto end = std::end(events);
+ if (!other.sorted) {
+ std::stable_sort(middle, end);
+ }
+
+ if (!sorted) {
+ std::stable_sort(begin, middle);
+ }
+ std::inplace_merge(begin, middle, end);
+ max_event_level = max_event_level > 0 ? max_event_level : other.max_event_level;
+ window = window > 0 ? window : other.window;
+
+ sorted = true;
+ }
+
+ void write(BufferWritable &out) const {
+ write_var_int(max_event_level, out);
+ write_var_int(window, out);
+ write_var_int(events.size(), out);
+
+ for (int64_t i = 0; i < events.size(); i++) {
+ int64_t timestamp = events[i].first;
+ int event_idx = events[i].second;
+ write_var_int(timestamp, out);
+ write_var_int(event_idx, out);
+ }
+ }
+
+ void read(BufferReadable& in) {
+ int64_t event_level;
+ read_var_int(event_level, in);
+ max_event_level = (int)event_level;
+ read_var_int(window, in);
+ int64_t size = 0;
+ read_var_int(size, in);
+ for (int64_t i = 0; i < size; i++) {
+ int64_t timestamp;
+ int64_t event_idx;
+
+ read_var_int(timestamp, in);
+ read_var_int(event_idx, in);
+ VecDateTimeValue time_value(timestamp);
+ add(time_value, (int)event_idx, max_event_level, window);
+ }
+ }
+};
+
+class AggregateFunctionWindowFunnel
+ : public IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel> {
+public:
+ AggregateFunctionWindowFunnel(const DataTypes& argument_types_)
+ : IAggregateFunctionDataHelper<WindowFunnelState,
+ AggregateFunctionWindowFunnel>(argument_types_, {}) {
+ }
+
+ String get_name() const override { return "window_funnel"; }
+
+ bool insert_to_null_default() const override { return false; }
Review comment:
if you are sure it never return null, you should put it in that `_SET`,
and it's may be better to return true about `insert_to_null_default`;
then it's never return null, I'm confused about `get_return_type` function , you add make_nullable about return type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818435085
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
1. From the point of view of function capabilities, single parentheses can meet the needs.
For example, ```intersect count``` is currently implemented in this way.
2. From the perspective of grammar compatibility, it depends on whether you want to follow the consistent syntax style of Doris or cater to CK.
In fact, much of the grammar of CK is not generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] dataroaring commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
dataroaring commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818427464
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
yeah, discussions are needed here on the grammar. I was considering that we could extends the function by adding modes parameter in ck, so I used ()()gramma like ck. If we use gramma with two brackets, then we can add modes parameters with backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818302071
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/logging.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/columns_number.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/io/var_int.h"
+
+namespace doris::vectorized {
+
+struct WindowFunnelState {
+ std::vector<std::pair<VecDateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void reset() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ std::vector<std::pair<VecDateTimeValue, int>> tmp;
Review comment:
Here can use shrink_to_fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818431531
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
1. From the point of view of function capabilities, single parentheses can meet the needs.
For example, ```intersect count``` is currently implemented in this way.
2. From the perspective of grammar compatibility, it depends on whether you want to follow the consistent syntax style of Doris or cater to CK.
In fact, much of the grammar of CK is not generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r817612721
##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -2265,6 +2265,206 @@ void AggregateFunctions::offset_fn_update(FunctionContext* ctx, const T& src, co
*dst = src;
}
+struct WindowFunnelState {
+ std::vector<std::pair<DateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void add(DateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
Review comment:
why use `stable_sort` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] dataroaring closed pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
dataroaring closed pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] dataroaring commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
dataroaring commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818422654
##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -2265,6 +2265,206 @@ void AggregateFunctions::offset_fn_update(FunctionContext* ctx, const T& src, co
*dst = src;
}
+struct WindowFunnelState {
+ std::vector<std::pair<DateTimeValue, int>> events;
+ int max_event_level;
+ bool sorted;
+ int64_t window;
+
+ WindowFunnelState() {
+ sorted = true;
+ max_event_level = 0;
+ window = 0;
+ }
+
+ void add(DateTimeValue& timestamp, int event_idx, int event_num, int64_t win) {
+ window = win;
+ max_event_level = event_num;
+ if (sorted && events.size() > 0) {
+ if (events.back().first == timestamp) {
+ sorted = events.back().second <= event_idx;
+ } else {
+ sorted = events.back().first < timestamp;
+ }
+ }
+ events.emplace_back(timestamp, event_idx);
+ }
+
+ void sort() {
+ if (sorted) {
+ return;
+ }
+ std::stable_sort(events.begin(), events.end());
Review comment:
std::sort is ok too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r820344685
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Function.java
##########
@@ -102,6 +102,8 @@
private Type retType;
// Array of parameter types. empty array if this function does not have parameters.
private Type[] argTypes;
+ // Only used by window_funnel()()
+ private Type[] leftParamsTypes;
Review comment:
Remove unused code ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818294081
##########
File path: be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
##########
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
Review comment:
This file maybe should add some declare.
You can refer to the following.
```
// This file is copied from
// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionWindowFunnel.h
// and modified by Doris
```
```
// Refer to TopNCounter.java in https://github.com/apache/kylin
// Based on the Space-Saving algorithm and the Stream-Summary data structure as described in:
// Efficient Computation of Frequent and Top-k Elements in Data Streams by Metwally, Agrawal, and Abbadi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8299: [feature] Window funnel
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818432279
##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
RESULT = new FunctionCallExpr(fn_name, params);
}
:}
+ | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN
Review comment:
hologres grammar https://help.aliyun.com/document_detail/216948.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org