You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/11 21:13:16 UTC

[jira] [Commented] (KAFKA-4619) Dissallow to output records with unknown keys in TransformValues

    [ https://issues.apache.org/jira/browse/KAFKA-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819185#comment-15819185 ] 

ASF GitHub Bot commented on KAFKA-4619:
---------------------------------------

GitHub user mjsax opened a pull request:

    https://github.com/apache/kafka/pull/2346

    KAFKA-4619: Dissallow to output records with unknown keys in TransformValues

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/kafka kafka-4619-fixTransformValues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2346
    
----
commit c988d4015dc678a86b3fa48d06169d4aad7d2504
Author: Matthias J. Sax <ma...@confluent.io>
Date:   2017-01-11T21:10:35Z

    KAFKA-4619: Dissallow to output records with unknown keys in TransformValues

----


> Dissallow to output records with unknown keys in TransformValues
> ----------------------------------------------------------------
>
>                 Key: KAFKA-4619
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4619
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.1.0, 0.10.0.0, 0.10.0.1, 0.10.1.1
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 0.10.2.0
>
>
> {{KStream#transformValues}} allows the user to return a new value in {{punctuate}} and it also allows the user to return any new key value pair using {{ProcesserContext#forward}}. For {{punctuate}} the key gets set to {{null}} under the hood and for {{forward}} the user can put any new key they want. However, Kafka Streams assumes that using {{transformValue}} does not change the key -- thus, this assumption might not hold right now resulting potentially incorrectly partitioned data.
> Thus, it should not be possible to return any data in {{punctuate}} and {{forward}} and we should raise an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)