You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org> on 2019/01/28 18:21:52 UTC
[native-toolchain-CR] Make unzip less verbose
hector.acosta@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12283
Change subject: Make unzip less verbose
......................................................................
Make unzip less verbose
extract_archive defaults to only printing errors, this change makes
unzipping/untarring behave similarly.
Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/83/12283/1
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
[native-toolchain-CR] Make unzip less verbose
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12283 )
Change subject: Make unzip less verbose
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 20:05:48 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Make unzip less verbose
Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Philip Zeyliger, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12283
to look at the new patch set (#2).
Change subject: Make unzip less verbose
......................................................................
Make unzip less verbose
extract_archive defaults to only printing errors, this change makes
unzipping/untarring behave similarly.
Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/83/12283/2
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Make unzip less verbose
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12283 )
Change subject: Make unzip less verbose
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 07:08:37 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Make unzip less verbose
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12283 )
Change subject: Make unzip less verbose
......................................................................
Make unzip less verbose
extract_archive defaults to only printing errors, this change makes
unzipping/untarring behave similarly.
Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Reviewed-on: http://gerrit.cloudera.org:8080/12283
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M functions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Laszlo Gaal: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 3
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Make unzip less verbose
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12283 )
Change subject: Make unzip less verbose
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8972572b34d115b2764373b28abd8252e2aa67
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 10:34:14 +0000
Gerrit-HasComments: No