[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #651: =remote Make ues of Netty's default resolver.

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #651:
URL: https://github.com/apache/incubator-pekko/pull/651#discussion_r1328731373


##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala:
##########
@@ -462,23 +462,12 @@ class NettyTransport(val settings: NettyTransportSettings, val system: ExtendedA
 
   override def isResponsibleFor(address: Address): Boolean = true // TODO: Add configurable subnet filtering
 
-  // TODO: This should be factored out to an async (or thread-isolated) name lookup service #2960
-  def addressToSocketAddress(addr: Address): Future[InetSocketAddress] = addr match {

Review Comment:
   Agreed about deprecation rather than removal, maybe there is a MiMa filter for this method, or more likely entire class or even sbt project since classic remoting was slated for removal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org