You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/08 09:57:07 UTC
[GitHub] [incubator-devlake] Startrekzky opened a new pull request, #4140: fix: home dashboard link and zentao dashboard
Startrekzky opened a new pull request, #4140:
URL: https://github.com/apache/incubator-devlake/pull/4140
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
- fix: dashboard link on the config-ui
- fix: add the missing zentao dashboard
### Does this close any open issues?
N/A
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #4140: fix: home dashboard link and zentao dashboard
Posted by GitBox <gi...@apache.org>.
klesh merged PR #4140:
URL: https://github.com/apache/incubator-devlake/pull/4140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4140: fix: home dashboard link and zentao dashboard
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #4140:
URL: https://github.com/apache/incubator-devlake/pull/4140#discussion_r1064266181
##########
config-ui/src/layouts/base/use-menu.ts:
##########
@@ -35,7 +35,7 @@ export type MenuItemType = {
export const useMenu = () => {
const getGrafanaUrl = () => {
- const suffix = '/d/lCO8w-pVk/homepage?orgId=1';
+ const suffix = 'd/lCO8w-pVk/homepage?orgId=1';
const { protocol, hostname } = window.location;
return process.env.LOCAL ? `${protocol}//${hostname}:3002${suffix}` : `/grafana/${suffix}`;
Review Comment:
`${protocol}//${hostname}:3002${suffix}` -> `${protocol}//${hostname}:3002/${suffix}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org