[jira] [Commented] (CASSANDRA-2720) The current implementation of CassandraConnection does not always follow documented semantics for a JDBC Connection interface

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042193#comment-13042193 ] 

Jonathan Ellis commented on CASSANDRA-2720:
-------------------------------------------

Not sure how to apply this patch. I get

{noformat}
form:svn-0.8 jonathan$ patch -p0 < Cleanup-semantics+for-a+JDBC-Connection-v1.txt 
patching file drivers/java/src/org/apache/cassandra/cql/jdbc/CassandraConnection.java
patch: **** malformed patch at line 76: this method");
{noformat}

Looks like the patch was run through something that inserted newlines into "long" lines, which is broken.

> The current implementation of CassandraConnection does not always follow documented semantics for a JDBC Connection interface
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2720
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2720
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 0.8.0 beta 2
>            Reporter: Rick Shaw
>            Assignee: Rick Shaw
>            Priority: Minor
>              Labels: cql, drivers, jdbc
>             Fix For: 0.8.1
>
>         Attachments: Cleanup-semantics for-a JDBC-Connection-v1.txt
>
>
> While the current implementation of many of the classes in the JDBC driver implementation are practical to get the driver to work they do not always obey the documented semantics for the associated interfaces. I am proposing making a pass over the involved implementation members to start the "tightening" process that will need to happen to use this driver in other tools an programs that expect stricter adherence than is currently present.
> Broad areas of attention are:
> - Use of {{SQLFeatureNotSupportedException}} not {{UnsupportedOperationException}} for methods that The Cassandra Implementation does not support.
> - Checking in appropriate methods for the prescribed throwing of {{SQLException}} if the method is called on a closed connection.
> - providing method implementations for all methods that are not optional even it it is to return NULL (as prescribed in the Interface description.)
> I will cut additional JIRA tickets for other components in the suite.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira