[GitHub] [arrow] mathyingzhou commented on a change in pull request #8648: ARROW-7906: [C++] Add ORC write support

[GitBox <gi...@apache.org>]

mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r550990299



##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -473,6 +453,80 @@ int64_t ORCFileReader::NumberOfStripes() { return impl_->NumberOfStripes(); }
 
 int64_t ORCFileReader::NumberOfRows() { return impl_->NumberOfRows(); }
 
+class ORCFileWriter::Impl {
+ public:
+  Status Open(Schema* schema, const std::shared_ptr<io::FileOutputStream>& file,
+              std::shared_ptr<liborc::WriterOptions> options,
+              std::shared_ptr<ArrowWriterOptions> arrow_options,

Review comment:
       Thanks! I have changed that. Note that `liborc::WriterOptions` need to be wrapped in ArrowWriterOptions which will be done in the next ORC writer/reader release.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org