You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/13 14:24:44 UTC
[GitHub] zentol commented on a change in pull request #6452: [FLINK-9739]
Regression in supported filesystems for RocksDB
zentol commented on a change in pull request #6452: [FLINK-9739] Regression in supported filesystems for RocksDB
URL: https://github.com/apache/flink/pull/6452#discussion_r209628463
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -535,10 +535,12 @@ else if (paths.length == 0) {
path = rawPath;
}
}
-
+ if (path.equalsIgnoreCase("file")) {
+ continue;
Review comment:
This means that `pp[i]` remains null, which we should avoid. We'll have to build a `List<File>` instead and convert it to a `File[]`.
Additionally we should document with a comment why we ignore this path here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services