You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/04/13 09:33:30 UTC
[GitHub] [maven] gnodet opened a new pull request, #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
gnodet opened a new pull request, #1085:
URL: https://github.com/apache/maven/pull/1085
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506761344
> For those that want to override it to the Maven 3 behaviour, maybe you can introduce a magic value "OS_DEFAULT" that gets translated to not setting the encoding deeper down the implementation?
>
> +1 to default to UTF-8
I'd prefer `system`. This is what I have done in other Maven components where empty was not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #1085:
URL: https://github.com/apache/maven/pull/1085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506722056
FTR: overwriting default values by empty string is not supported due to https://github.com/eclipse/sisu.plexus/issues/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506680405
> > The outcome is then there is no way to remove this and it will also apply to ALL projects.
>
> Isn't that the goal ? Also you can't remove the property, but you can override it, which is very often the case (else you actually have a warning).
Maybe, but this should be known that due to Plexus we cannot null values. @kwin Can we know? I don't that this is a huge problem here, but people should still know whether it is possible or not. I haven't used anything else, but UTF-8 for the past 20 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506800947
> > For those that want to override it to the Maven 3 behaviour, maybe you can introduce a magic value "OS_DEFAULT" that gets translated to not setting the encoding deeper down the implementation?
> > +1 to default to UTF-8
>
> I'd prefer `system`. This is what I have done in other Maven components where empty was not allowed.
I'd suggest that people that want the default encoding use `${file.encoding}` so that we don't have to do any hack in maven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] ge0ffrey commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "ge0ffrey (via GitHub)" <gi...@apache.org>.
ge0ffrey commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506758507
For those that want to override it to the Maven 3 behaviour, maybe you can introduce a magic value "OS_DEFAULT" that gets translated to not setting the encoding deeper down the implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506695996
while you can override it in your own project (which is the case AFAIK) it is fine and I don't see how null and not be deterministic can be better than forcing the value to the OS one so guess we are good like that without handling null in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] ge0ffrey commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "ge0ffrey (via GitHub)" <gi...@apache.org>.
ge0ffrey commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506764040
For what's it worth, I ran an online poll around this topic a few days ago:
I might have revealed my bias a bit in how I posed the question :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506822616
> > > For those that want to override it to the Maven 3 behaviour, maybe you can introduce a magic value "OS_DEFAULT" that gets translated to not setting the encoding deeper down the implementation?
> > > +1 to default to UTF-8
> >
> >
> > I'd prefer `system`. This is what I have done in other Maven components where empty was not allowed.
>
> I'd suggest that people that want the default encoding use `${file.encoding}` so that we don't have to do any hack in maven.
You are totally right. Stupid me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506666699
The outcome is then there is no way to remove this and it will also apply to ALL projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] ge0ffrey commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "ge0ffrey (via GitHub)" <gi...@apache.org>.
ge0ffrey commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506762740
Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1085: [MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1085:
URL: https://github.com/apache/maven/pull/1085#issuecomment-1506677655
> The outcome is then there is no way to remove this and it will also apply to ALL projects.
Isn't that the goal ?
Also you can't remove the property, but you can override it, which is very often the case (else you actually have a warning).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org