You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/07/09 11:11:17 UTC
[Apache Bloodhound] #588: Integrate duplicate relations to ticket
workflow
#588: Integrate duplicate relations to ticket workflow
-------------------------+------------------
Reporter: astaric | Owner: anze
Type: enhancement | Status: new
Priority: major | Milestone:
Component: relations | Version:
Keywords: |
-------------------------+------------------
There are currently two ways to mark duplicated tickets. They can be
either related with duplicateof relation or closed as duplicate. With
second approach, there is currently no way to indicate the duplicated
ticket.
Close as a duplicated workflow should be extended with a field that can be
used to enter the duplicated ticket id. If id is entered, a "duplicate of"
relations should also be created when the ticket is closed. If the ticket
already has a "duplicate of" relation, the value of the field should be
prefilled.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by astaric):
If you do not mind, I will modify the if to check for the path, as you
have suggested in comment:3. Checking if data is not None is another
approach, but I guess other plugins use the path check because it is
cleaner (and will not break if unrelated process_requests do stuff we did
not anticipate).
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by rjollos):
I'm seeing the following traceback when navigating to the //Source// tab
on the mainnav, for the case that the repository hasn't been configured
and the user has `TRAC_ADMIN` permission, resulting in the tab directing
to `/wiki/Guide/RepositoryAdmin`.
{{{#!python
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 46427)
Traceback (most recent call last):
File "/usr/lib/python2.6/SocketServer.py", line 560, in
process_request_thread
self.finish_request(request, client_address)
File "/usr/lib/python2.6/SocketServer.py", line 322, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python2.6/SocketServer.py", line 617, in __init__
self.handle()
File "/usr/lib/python2.6/BaseHTTPServer.py", line 331, in handle
self.handle_one_request()
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/wsgi.py", line
191, in handle_one_request
gateway.run(self.server.application)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/wsgi.py", line
91, in run
response = application(self.environ, self._start_response)
File
"/home/user/Workspace/bh585/bloodhound/trac/trac/web/standalone.py", line
117, in __call__
return self.application(environ, start_response)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
445, in dispatch_request
return _dispatch_request(req, env, env_error)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
484, in _dispatch_request
send_internal_error(env, req, sys.exc_info())
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
615, in send_internal_error
req.send_error(exc_info, status=500, env=env, data=data)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/api.py", line
536, in send_error
exc_info)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
477, in _dispatch_request
dispatcher.dispatch(req)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
236, in dispatch
self._post_process_request(req)
File "/home/user/Workspace/bh585/bloodhound/trac/trac/web/main.py", line
340, in _post_process_request
f.post_process_request(req, *(None,)*extra_arg_count)
File
"/home/user/Workspace/bh585/bloodhound/bloodhound_relations/bhrelations/web_ui.py",
line 134, in post_process_request
if 'ticket' in data:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: relations | Version:
Resolution: | Keywords:
--------------------------+----------------------
Changes (by astaric):
* owner: anze => astaric
* status: new => accepted
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by astaric):
I have added code that handles cases when resource cannot be constructed
from the provided instance in r1502480. It fixes the described issue.
If you think that checking the path_info is a better idea than checking
for presence of keys in data dict, commit your change as well.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by rjollos):
Replying to [comment:5 astaric]:
> If you think that checking the path_info is a better idea than checking
for presence of keys in data dict, commit your change as well.
I don't have a solid argument for making the change at the moment, so I'll
leave it as is. I just mentioned, because checking the `path_info` looks
more familiar to me from all of the plugins I've worked with. One possible
advantage is that you'll send less time in `post_process_request` when
loading the `/newticket` page, but I can't say that is significant.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by matevzb):
Replying to [comment:12 rjollos]:
> Should this ticket be closed for [milestone:"Release 7"]? It appears the
main goals have been accomplished, but I just wanted to check to be sure.
It seems so, the feature was completed. Any issues should be reported as
new tickets, closing this one.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: relations | Version:
Resolution: | Keywords:
--------------------------+----------------------
Comment (by rjollos):
This change fixes the issue, but I won't commit just yet in case there is
a better fix.
{{{#!diff
Index: bloodhound/bloodhound_relations/bhrelations/web_ui.py
===================================================================
--- bloodhound/bloodhound_relations/bhrelations/web_ui.py (revision
1502387)
+++ bloodhound/bloodhound_relations/bhrelations/web_ui.py (working
copy)
@@ -131,7 +131,7 @@
return handler
def post_process_request(self, req, template, data, content_type):
- if 'ticket' in data:
+ if req.path_info.startswith('/ticket/'):
ticket = data['ticket']
rls = RelationsSystem(self.env)
resid = ResourceIdSerializer.get_resource_id_from_instance(
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Changes (by rjollos):
* milestone: => Release 7
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone:
Component: relations | Version:
Resolution: | Keywords:
--------------------------+----------------------
Comment (by rjollos):
Here is an issue that has been introduced in [1501152]. Requests to
`/newticket` fail with:
----
==== How to Reproduce ====
While doing a GET operation on `/newticket`, Trac issued an internal
error.
''(please provide additional details here)''
Request parameters:
{{{
{}
}}}
User agent: `Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Ubuntu Chromium/28.0.1500.52 Chrome/28.0.1500.52
Safari/537.36`
==== System Information ====
|| '''`Trac`''' || `1.0.1` [[br]] `` ||
|| '''`Babel`''' || `0.9.6` ||
|| '''`Bloodhound Trac`''' || `1.0.1` ||
|| '''`Genshi`''' || `0.7 (with speedups)` ||
|| '''`Pygments`''' || `1.6` ||
|| '''`pysqlite`''' || `2.4.1` ||
|| '''`Python`''' || `2.6.8 (default, Apr 26 2013, 17:05:01) ` [[br]]
`[GCC 4.7.3]` ||
|| '''`pytz`''' || `2013b` ||
|| '''`setuptools`''' || `0.6` ||
|| '''`SQLite`''' || `3.7.15.2` ||
|| '''`jQuery`''' || `1.7.2` ||
==== Enabled Plugins ====
|| '''`bhrelations.widgets.relations`''' || `N/A` ||
|| '''`BloodhoundDashboardPlugin`''' || `0.7.0dev` ||
|| '''`BloodhoundMultiProduct`''' || `0.7.0dev` ||
|| '''`BloodhoundRelationsPlugin`''' || `0.7.0dev` ||
|| '''`BloodhoundSearchPlugin`''' || `0.7.0dev` ||
|| '''`BloodhoundTheme`''' || `0.7.0dev` ||
|| '''`TracAccountManager`''' || `0.4.3` ||
|| '''`TracPermRedirect`''' || `3.0` ||
|| '''`TracThemeEngine`''' || `2.2.0` ||
==== Python Traceback ====
{{{
Traceback (most recent call last):
File "/home/user/Workspace/bh586/bloodhound/trac/trac/web/main.py", line
477, in _dispatch_request
dispatcher.dispatch(req)
File "/home/user/Workspace/bh586/bloodhound/trac/trac/web/main.py", line
224, in dispatch
self._post_process_request(req, *resp)
File "/home/user/Workspace/bh586/bloodhound/trac/trac/web/main.py", line
338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/home/user/Workspace/bh586/bloodhound/bloodhound_relations/bhrelations/web_ui.py",
line 138, in post_process_request
self.env, ticket)
File
"/home/user/Workspace/bh586/bloodhound/bloodhound_relations/bhrelations/api.py",
line 451, in get_resource_id_from_instance
(nbhprefix, resource.realm, unicode(resource.id))
TypeError: sequence item 0: expected string or Unicode, NoneType found
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by rjollos):
Sounds good to me. In comment:7, I mentioned specifically that the error
could occur when navigating to the //Source// tab, but once I properly
enabled logging at the debug level, I saw the error for every path in
Bloodhound that I checked (`/dashboard`, `/wiki`, `/admin/logging`, ...).
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by olemis):
Related to #611
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: closed
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: fixed | Keywords:
--------------------------+-----------------------
Changes (by matevzb):
* status: accepted => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by rjollos):
Should this ticket be closed for [milestone:"Release 7"]? It appears the
main goals have been accomplished, but I just wanted to check to be sure.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #588: Integrate duplicate relations to
ticket workflow
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#588: Integrate duplicate relations to ticket workflow
--------------------------+-----------------------
Reporter: astaric | Owner: astaric
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 7
Component: relations | Version:
Resolution: | Keywords:
--------------------------+-----------------------
Comment (by astaric):
r1503125:
Check path_info instead of presence of 'ticket' in data to detect ticket
page.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/588#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker