You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:14:28 UTC

[GitHub] [druid] FrankChen021 commented on a diff in pull request #13087: Don't wait for graceful shutdown on failed start

FrankChen021 commented on code in PR #13087:
URL: https://github.com/apache/druid/pull/13087#discussion_r990616037


##########
server/src/main/java/org/apache/druid/curator/CuratorModule.java:
##########
@@ -96,7 +98,26 @@ public CuratorFramework makeCurator(ZkEnablementConfig zkEnablementConfig, Curat
     final CuratorFramework framework = createCurator(config);
 
     framework.getUnhandledErrorListenable().addListener((message, e) -> {
+      final long startTime = System.currentTimeMillis();
       log.error(e, "Unhandled error in Curator, stopping server.");
+      final Thread halter = new Thread(
+          () -> {
+            try {
+              Threads.sleepFor(30, TimeUnit.SECONDS);
+            }
+            catch (InterruptedException ex) {

Review Comment:
   ```suggestion
               catch (InterruptedException ignored) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org