You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by AlexMouton <gi...@git.apache.org> on 2015/04/10 00:22:45 UTC
[GitHub] cordova-ios pull request: CB 8838 wkwebview double call
GitHub user AlexMouton opened a pull request:
https://github.com/apache/cordova-ios/pull/135
CB 8838 wkwebview double call
Hi Shazron
I am working on an html5 video game that is packaged for ios using cordova.
We were having memory issues with UIWebView and have integrated your work on WKWebView recently.
Its working great for the performance! thanks! but, we are of course feeling alpha growing pains.
One thing we have noticed is that when we invoke the cordova Barcode plugin, it is always called twice!
I have only looked at the code a short time, but it appears to me that:
* the first call to Barcode happens, and in iosExec, it gets placed in commandQueue.
* the first call passes to Objective C world by WKScriptMessageHandler - (void)userContentController:(WKUserContentController*)userContentController didReceiveScriptMessage:(WKScriptMessage*)message
* this call to Barcode does its thing, completes, and it's javascript response handler code winds through:
CDVCommandDelegateImpl::sendPluginResult
CDVCommandDelegateImpl::evalJSHelper
CDVCommandDelegateImpl::evalJSHelper2
* in Helper2, the callback is finally passed to a webViewEngine, which processes the Javascript, and returns, on completion, a list of commands remaining in the javascript commandQueue.
* these commands are queued on the Obj-C side and run in CDVCommandQueue fashion.
AHA!
* since the command was persisted in commandQueue before execution, and not removed, it is called again!
SO
I moved the enqueue behavior into the branch that excludes bridgeMode === jsToNativeModes.WK_WEBVIEW_BINDING
This fixes it, but I am not confident its the right solution.
Do you have any insight into this problem?
Feedback for my solution?
A broader or more appropriate venue for the conversation?
Thanks!
Alex Mouton
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skcamp/cordova-ios CB-8838-wkwebview-double-call
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit aa5d0e937ac68b10aa846d439bb1baba4da12049
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-14T19:03:19Z
WKWebView - squashed commit.
commit da7a3546f809c331cf230af180b3e6f1fb99cb2b
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jul 10 17:48:15 2014 -0700
Support alert/confirm/prompt in WKWebView
commit 63552fd3f2548f407aec1bbfda997809d1f2a89d
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jul 10 14:52:44 2014 -0700
Support config.xml preferences for WKWebView, and style fixups
commit e67e6bf2577c776c887453801af05f973fb90094
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:44:03 2014 -0700
Use weakSelf in block
commit fc83f068388f3402935819f7891906ffa9029cc1
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:38:30 2014 -0700
Support config.xml preferences for WKWebView
commit 4eeaf0c8730a30b8709d0d98aba4b2996e34d9f4
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:27:51 2014 -0700
Break out config.xml preferences for UIWebView (related to WKWebView prefs support)
commit 9ba496297116f20a4ea0d7b83a9f142ceec2bc84
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 17:51:11 2014 -0700
Re-add pragma message for iOS 8
commit 2e17db94a87da80a7d50f202eef40178c0a688c0
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 17:46:00 2014 -0700
Removed unused WKWebView+Private header
commit 601eea1c8784e1acf00b0a39ca4a3ea5085b2098
Author: Shazron Abdullah <sh...@apache.org>
Date: Mon Jul 7 15:59:30 2014 -0700
Removed WKWebView+Private category since the functions it covers are already now in iOS 8 beta 3
commit 69c86d641c8a14e23843566ff2024ce77238fd79
Author: Shazron Abdullah <sh...@apache.org>
Date: Mon Jun 23 11:59:51 2014 -0700
Changed @import WebKit back to the old #import (for supporting older IPHONE_OS_DEPLOYMENT_TARGET reasons, bug in Xcode), add #pragma message to add WebKit.framework for iOS 8
commit c133640d264eba5456b3ffd2d3be83e3fd90bf42
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 22:14:26 2014 -0700
Removed WebKit.framework from templates.
commit b4832d132e6628a7ae0ef681eab54554ed913b77
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 21:45:10 2014 -0700
Using @import instead of #import for WebKit, which doesn't require us to list the framework in the project explicitly.
This gives us a true Xcode 5 / 6 compile solution. HOWEVER there is a bug in Xcode (was there since 5) where if you do an @import for a framework, it won't link if your Deployment Target OS version does not also include the framework itself, when compiling for the Simulator. For example, if you @import WebKit, and build for the Simulator, your Deployment Target MUST be iOS 8.
The workaround is, this bug does not appear if you build for a device. To make it work for the Simulator, you will have to explicitly add the framework in Build Phases -> Link Binary with Libraries.
commit df3d8391546b2bb6da659ca2102609beb7038f7d
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 00:20:36 2014 -0700
Unified the implementations to switch to WKWebView when available and fall back to UIWebView. The implementation even compiles under Xcode 5.1 -- however, the linker will complain under Xcode 5.1 that WebKit.framework is not available. Just remove the framework in "Link Binary With Libraries" Build Phase and it should run.
commit 52e27adcd4227621d329fea4743be73bfcb7f4bf
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:59:48 2014 -0700
Re-add deprecated CDVPlugin functions
commit e16e914c3ba2f30324f25da27fbbc0efa9cde727
Merge: f3af6f2 2e1b00c
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:51:54 2014 -0700
Merge branch 'wkwebview-only' of github.com:shazron/cordova-ios into wkwebview-only
Conflicts:
CordovaLib/Classes/CDVPlugin.h
commit f3af6f2636dad50412da329ce7c21dfaf3717254
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:22:08 2014 -0700
Changed webView property of CDVPlugin to UIView.
Plugins need to coerce this into a UIWebView or WKWebView.
commit c33497742cfe9c7f0e2c7c8902b56cf6fba09ad9
Author: Shazron Abdullah <sh...@gmail.com>
Date: Thu Jun 19 21:39:07 2014 -0700
Fixed native commands not being called when called in a exec callback
commit b155b5d9e120a1b7ec2d4a8c3950073792281df5
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:22:04 2014 -0700
Added new cordova.js to support WKWebView Cordova bridge
commit 6a96341da8d0f455ed9f977e6329af6d98c357fe
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:08:30 2014 -0700
Implemented the WKWebView Cordova bridge.
commit 6eb29c716b8308a7f4824a313a232c7c16f421b8
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 13:42:49 2014 -0700
Moved WKScriptMessageHandler to CDVCommandDelegateImpl
commit 374763daf13f73df872a64caa83a7371a0c58542
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:51:51 2014 -0700
Updated templates for WebKit.framework use
commit be7fd66f708587bee48b9dbbc7c0b57b03002eb2
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:50:28 2014 -0700
Updated AppDelegate.m to use WKWebView evaluateJavascript (private)
commit 05b5c5912e339d29623de75127c2f162e0c875ed
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:54 2014 -0700
Added WKWebView support (not unified, stripped out UIWebView use)
commit a6ebfb01a7dbad504928b871783f75bbc95e0d85
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:00 2014 -0700
Added WKWebView private functions.
commit 2e1b00cbb92164114db2f30df10b7f0ec918c9bc
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:22:08 2014 -0700
Changed webView property of CDVPlugin to UIView.
Plugins need to coerce this into a UIWebView or WKWebView.
commit 867647075c837c3782333eb6b4c865cb70451aa3
Author: Shazron Abdullah <sh...@gmail.com>
Date: Thu Jun 19 21:39:07 2014 -0700
Fixed native commands not being called when called in a exec callback
commit ad3ec2937633995309b77bc663ee22e0b07ac667
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:22:04 2014 -0700
Added new cordova.js to support WKWebView Cordova bridge
commit ede3ad5cef804c67e777c0f2c750712df50883f5
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:08:30 2014 -0700
Implemented the WKWebView Cordova bridge.
commit c1c39086ab220fcdc5a796b27d38a5d32f7f5f37
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 13:42:49 2014 -0700
Moved WKScriptMessageHandler to CDVCommandDelegateImpl
commit 5d2b137645e5fffb460c8e84d16dc8f5d104d085
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:51:51 2014 -0700
Updated templates for WebKit.framework use
commit 63bf9a7ca03f92f263a3a3d7226512aee784a171
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:50:28 2014 -0700
Updated AppDelegate.m to use WKWebView evaluateJavascript (private)
commit 23c05db85e57f82a4c6fe03fc5faf49abaf947b8
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:54 2014 -0700
Added WKWebView support (not unified, stripped out UIWebView use)
commit 74a0f4e678e4349849596f23f7f0714aaa574532
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:00 2014 -0700
Added WKWebView private functions.
commit 28b4475070cd61587c8e7ac8e7f0102d8101367f
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-17T23:48:13Z
Moved CDVWebViewUIDelegate into Classes folder
commit 6d6ab0a161f93eee92faa1d3888318e3144e6f29
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:02:43Z
CB-7182 - Running mobile-spec in an iOS 8 project but using UIWebView results in an exception
commit 641992c4860ea107cefb0aae7c3dad2d04b156ca
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:34:05Z
CB-7047 - Support config.xml preferences for WKWebView
commit 7ce625ba9279716e4a2f3958a49bf31e13e87fcd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:43:36Z
CB-7047 - typo fix
commit 3d39ef4e34e2ff994ee725fe5e2b956334eee854
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:48:51Z
CB-7184 - Implement support for mediaPlaybackAllowsAirPlay in UIWebView and WKWebView
plus config cleanup.
commit 1e84e301b098385a9b67a620c589c55b515db771
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-22T05:25:20Z
Merge branch 'master' into wkwebview
Conflicts:
CordovaLib/Classes/CDVPlugin.h
CordovaLib/CordovaLib.xcodeproj/project.pbxproj
bin/templates/project/__CLI__.xcodeproj/project.pbxproj
bin/templates/project/__NON-CLI__.xcodeproj/project.pbxproj
commit 89555725cedd25b45e2d69953203cb23ead05fd6
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-08-14T06:29:25Z
Added logs to show if you are using a WKWebView or UIWebView.
commit 2a38ad254de202b7aef893427f5c08de2903a415
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-08-14T06:33:44Z
CB-6884 - Support new Cordova bridge under iOS 8 WKWebView (typo fix)
commit 1a759ac7fd7fa24aa658f868dbf413ef8ca34396
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-14T19:03:19Z
WKWebView - squashed commit.
commit da7a3546f809c331cf230af180b3e6f1fb99cb2b
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jul 10 17:48:15 2014 -0700
Support alert/confirm/prompt in WKWebView
commit 63552fd3f2548f407aec1bbfda997809d1f2a89d
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jul 10 14:52:44 2014 -0700
Support config.xml preferences for WKWebView, and style fixups
commit e67e6bf2577c776c887453801af05f973fb90094
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:44:03 2014 -0700
Use weakSelf in block
commit fc83f068388f3402935819f7891906ffa9029cc1
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:38:30 2014 -0700
Support config.xml preferences for WKWebView
commit 4eeaf0c8730a30b8709d0d98aba4b2996e34d9f4
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 18:27:51 2014 -0700
Break out config.xml preferences for UIWebView (related to WKWebView prefs support)
commit 9ba496297116f20a4ea0d7b83a9f142ceec2bc84
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 17:51:11 2014 -0700
Re-add pragma message for iOS 8
commit 2e17db94a87da80a7d50f202eef40178c0a688c0
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jul 9 17:46:00 2014 -0700
Removed unused WKWebView+Private header
commit 601eea1c8784e1acf00b0a39ca4a3ea5085b2098
Author: Shazron Abdullah <sh...@apache.org>
Date: Mon Jul 7 15:59:30 2014 -0700
Removed WKWebView+Private category since the functions it covers are already now in iOS 8 beta 3
commit 69c86d641c8a14e23843566ff2024ce77238fd79
Author: Shazron Abdullah <sh...@apache.org>
Date: Mon Jun 23 11:59:51 2014 -0700
Changed @import WebKit back to the old #import (for supporting older IPHONE_OS_DEPLOYMENT_TARGET reasons, bug in Xcode), add #pragma message to add WebKit.framework for iOS 8
commit c133640d264eba5456b3ffd2d3be83e3fd90bf42
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 22:14:26 2014 -0700
Removed WebKit.framework from templates.
commit b4832d132e6628a7ae0ef681eab54554ed913b77
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 21:45:10 2014 -0700
Using @import instead of #import for WebKit, which doesn't require us to list the framework in the project explicitly.
This gives us a true Xcode 5 / 6 compile solution. HOWEVER there is a bug in Xcode (was there since 5) where if you do an @import for a framework, it won't link if your Deployment Target OS version does not also include the framework itself, when compiling for the Simulator. For example, if you @import WebKit, and build for the Simulator, your Deployment Target MUST be iOS 8.
The workaround is, this bug does not appear if you build for a device. To make it work for the Simulator, you will have to explicitly add the framework in Build Phases -> Link Binary with Libraries.
commit df3d8391546b2bb6da659ca2102609beb7038f7d
Author: Shazron Abdullah <sh...@gmail.com>
Date: Sat Jun 21 00:20:36 2014 -0700
Unified the implementations to switch to WKWebView when available and fall back to UIWebView. The implementation even compiles under Xcode 5.1 -- however, the linker will complain under Xcode 5.1 that WebKit.framework is not available. Just remove the framework in "Link Binary With Libraries" Build Phase and it should run.
commit 52e27adcd4227621d329fea4743be73bfcb7f4bf
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:59:48 2014 -0700
Re-add deprecated CDVPlugin functions
commit e16e914c3ba2f30324f25da27fbbc0efa9cde727
Merge: f3af6f2 2e1b00c
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:51:54 2014 -0700
Merge branch 'wkwebview-only' of github.com:shazron/cordova-ios into wkwebview-only
Conflicts:
CordovaLib/Classes/CDVPlugin.h
commit f3af6f2636dad50412da329ce7c21dfaf3717254
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:22:08 2014 -0700
Changed webView property of CDVPlugin to UIView.
Plugins need to coerce this into a UIWebView or WKWebView.
commit c33497742cfe9c7f0e2c7c8902b56cf6fba09ad9
Author: Shazron Abdullah <sh...@gmail.com>
Date: Thu Jun 19 21:39:07 2014 -0700
Fixed native commands not being called when called in a exec callback
commit b155b5d9e120a1b7ec2d4a8c3950073792281df5
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:22:04 2014 -0700
Added new cordova.js to support WKWebView Cordova bridge
commit 6a96341da8d0f455ed9f977e6329af6d98c357fe
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:08:30 2014 -0700
Implemented the WKWebView Cordova bridge.
commit 6eb29c716b8308a7f4824a313a232c7c16f421b8
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 13:42:49 2014 -0700
Moved WKScriptMessageHandler to CDVCommandDelegateImpl
commit 374763daf13f73df872a64caa83a7371a0c58542
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:51:51 2014 -0700
Updated templates for WebKit.framework use
commit be7fd66f708587bee48b9dbbc7c0b57b03002eb2
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:50:28 2014 -0700
Updated AppDelegate.m to use WKWebView evaluateJavascript (private)
commit 05b5c5912e339d29623de75127c2f162e0c875ed
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:54 2014 -0700
Added WKWebView support (not unified, stripped out UIWebView use)
commit a6ebfb01a7dbad504928b871783f75bbc95e0d85
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:00 2014 -0700
Added WKWebView private functions.
commit 2e1b00cbb92164114db2f30df10b7f0ec918c9bc
Author: Shazron Abdullah <sh...@apache.org>
Date: Fri Jun 20 16:22:08 2014 -0700
Changed webView property of CDVPlugin to UIView.
Plugins need to coerce this into a UIWebView or WKWebView.
commit 867647075c837c3782333eb6b4c865cb70451aa3
Author: Shazron Abdullah <sh...@gmail.com>
Date: Thu Jun 19 21:39:07 2014 -0700
Fixed native commands not being called when called in a exec callback
commit ad3ec2937633995309b77bc663ee22e0b07ac667
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:22:04 2014 -0700
Added new cordova.js to support WKWebView Cordova bridge
commit ede3ad5cef804c67e777c0f2c750712df50883f5
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 16:08:30 2014 -0700
Implemented the WKWebView Cordova bridge.
commit c1c39086ab220fcdc5a796b27d38a5d32f7f5f37
Author: Shazron Abdullah <sh...@apache.org>
Date: Thu Jun 19 13:42:49 2014 -0700
Moved WKScriptMessageHandler to CDVCommandDelegateImpl
commit 5d2b137645e5fffb460c8e84d16dc8f5d104d085
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:51:51 2014 -0700
Updated templates for WebKit.framework use
commit 63bf9a7ca03f92f263a3a3d7226512aee784a171
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:50:28 2014 -0700
Updated AppDelegate.m to use WKWebView evaluateJavascript (private)
commit 23c05db85e57f82a4c6fe03fc5faf49abaf947b8
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:54 2014 -0700
Added WKWebView support (not unified, stripped out UIWebView use)
commit 74a0f4e678e4349849596f23f7f0714aaa574532
Author: Shazron Abdullah <sh...@apache.org>
Date: Wed Jun 18 17:49:00 2014 -0700
Added WKWebView private functions.
commit 4c0556bd611d3f93fa119592e2d16f37163b6925
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-17T23:48:13Z
Moved CDVWebViewUIDelegate into Classes folder
commit 686ef8a3a8c6c5cc1d025d9a5010dd28e6380206
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:02:43Z
CB-7182 - Running mobile-spec in an iOS 8 project but using UIWebView results in an exception
commit d801bacac2a41ff730bd8aa6967004ea6bf3f82b
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:34:05Z
CB-7047 - Support config.xml preferences for WKWebView
commit e22c8fb73cee4c44eac3803b51e4b632098d0795
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:43:36Z
CB-7047 - typo fix
commit b3fbd850672a2cccb5163bca3720d618118d72bd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-07-21T21:48:51Z
CB-7184 - Implement support for mediaPlaybackAllowsAirPlay in UIWebView and WKWebView
plus config cleanup.
commit 1c1e9c30d7bed52d8d9dce93717e03f587df26c4
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-08-14T06:29:25Z
Added logs to show if you are using a WKWebView or UIWebView.
commit f6d89c6a9474c194ce9f9d8b86fda652f1c7503f
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-08-14T06:33:44Z
CB-6884 - Support new Cordova bridge under iOS 8 WKWebView (typo fix)
commit 1a7dbfa65bec49f9ef003bd2bd5b4d2bff9dd71d
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-10-31T23:28:53Z
Fixed processOpenUrl and userContentController:didReceiveScriptMessage bad merge.
Converted processOpenUrl to use the webViewOperationsDelegate.
commit f13ba3a49405db39cb2856fe10804eee8b6a835e
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-10-31T23:39:10Z
Merge branch 'wkwebview' of https://git-wip-us.apache.org/repos/asf/cordova-ios into wkwebview
Conflicts:
CordovaLib/Classes/CDVCommandDelegateImpl.m
CordovaLib/Classes/CDVViewController.m
CordovaLib/CordovaLib.xcodeproj/project.pbxproj
CordovaLib/cordova.js
bin/templates/project/__PROJECT_NAME__/Classes/AppDelegate.m
commit 3a4182461d22c2477dab58e8ebe0d3604216b2e4
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-02T07:02:07Z
Add support for loadFileUrl (and style mixups)
commit 46910664ac236c2d75d9c5e7c9a0134a8e3b2e40
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-02T07:07:21Z
Renamed CDVWebViewOperationsDelegate to CDVWebViewProxy (plus uncrustify style fixups)
commit 9ec77c098156d10b91771472b89cd6bc7f16fb4a
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-03T08:40:48Z
Modularized CDVWebViewPreferences.
commit 5bb42457549a29f3720b3b1ce75c65f01e3db48a
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-03T09:21:43Z
Cleaned up CDVWebViewProxy code for redundancies.
commit ce6604dbf1f2e0ecc5f80a94da9da88eac287561
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-06T10:07:05Z
Separate the WebViews into plugins, prep for plugin breakout (plus style mixups)
commit af1ec2c40e2fb5ae4d01c87407a64d25d0b85b02
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-06T23:28:13Z
Removed WebKit.framework dependencies in core files, WKWebView and UIWebView are fully pluginized. WKWebView will need a local web server for use on device currently (Simulator is fine)
commit 03e9c7162a9ae91648eaf3a8f89928a8ad5ce961
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-07T00:14:40Z
Removed the WKWebViewEngine. The plugin now exists in the cordova-plugins repo.
commit 96fd4cb74022962815ba2daf1e7b146e1fbd4db2
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-07T18:31:21Z
Removed the CordovaWebViewEngine preference. This will be installed by the wkwebview-engine plugin.
commit c343e2ec3ab1d1956f28b7c6b052bf7136fb5cc0
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-07T20:08:08Z
Fixed the failing unit-tests, plus style fix-ups.
Note that some of these tests, like the User-Agent tests, are specific to UIWebView and are treated as such. The StartPage test should also work for WKWebView, and should be changed to support that as well, although it is not trivial.
commit 3487ffba992bd3f2cca447d357f6768f0dacaf37
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2014-11-10T17:43:37Z
Use default web view engine (UIWebView) if external web engine is not supported in the current runtime version, or it doesn't conform to the protocol.
commit 62aa5b854d0616507785e44f0747c49efdf1d59b
Author: Shazron Abdullah <sh...@apache.org>
Date: 2014-11-10T22:19:39Z
Remove deleted preference from config.xml in the test app.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB 8838 wkwebview double call
Posted by AlexMouton <gi...@git.apache.org>.
Github user AlexMouton closed the pull request at:
https://github.com/apache/cordova-ios/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org