You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/08/06 07:17:22 UTC

Re: Review Request 12430: Added "argv" lookup for Process::command on OS X.


> On July 12, 2013, 2:22 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp, line 80
> > <https://reviews.apache.org/r/12430/diff/2/?file=320713#file320713line80>
> >
> >     Do you trust tokens to be non-empty always here?

Wrapped in an 'if (!tokens.empty())'.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12430/#review23055
-----------------------------------------------------------


On July 12, 2013, 1:23 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12430/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 1:23 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp e8429b997cdefd703ef16249789750fe7d8ac9c4 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7ec94468df3d447a0c30ad9c82fa4c2fe91deb7e 
> 
> Diff: https://reviews.apache.org/r/12430/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>