You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/03 00:01:43 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

rkhachatryan opened a new pull request #18964:
URL: https://github.com/apache/flink/pull/18964


   ## What is the purpose of the change
   
   When the task is cancelled, AsyncCheckpointRunnables are cancelled as well.
   Cancellation exception can reach PeriodicMaterializationManager.
   When the failure limit is reached, it invokes asyncExceptionHandler.handleAsyncException, which fails the job.
   
   ## Verifying this change
   
   ChangelogITCase (FLINK-25143)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r819401856



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       I am confused why this change is needed.
   - If a task gets a `CancellationException`, shouldn't it fail the whole job?
   - Why checkpoint abortion notification can pass `CancellationException` to the part of materialization? Materialization should be independent of Checkpointing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rkhachatryan commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r819593982



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       > If a task gets a CancellationException, shouldn't it fail the whole job?
   
   No, task cancellation doesn't mean job failure.
   
   > Why checkpoint abortion notification can pass CancellationException to the part of materialization? Materialization should be independent of Checkpointing.
   
   Currently, the issue happens only because of task cancellation; abortion notification can not reach the nested backend and therefore materializer. But with FLINK-25850 it will be possible. So I added this comment and decided not to react to `CancellationException` (e.g. by stopping the materializer).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820496629



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       "Nested Abortion of Checkpoint" can be propogated, but it should not be propagated to the Materialization Manager.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rkhachatryan commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820504848



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       Regarding the code, do you disagree only with the comment -the part about checkpoint abortion?
   If so, I could remove that part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820493182



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       > > If a task gets a CancellationException, shouldn't it fail the whole job?
   > 
   > No, task cancellation doesn't mean job failure.
   
   This is true.
   
   > > Why checkpoint abortion notification can pass CancellationException to the part of materialization? Materialization should be independent of Checkpointing.
   > 
   > Currently, the issue happens only because of task cancellation; abortion notification can not reach the nested backend and therefore materializer. But with [FLINK-25850](https://issues.apache.org/jira/browse/FLINK-25850) it will be possible. So I added this comment and decided not to react to `CancellationException` (e.g. by stopping the materializer).
   
   The checkpoint should be independent of Materialization? Checkpoint abortion should not affect materialization. That's the main purpose of separating materialization out from checkpointing procedure. 
   
   I can not agree on this part.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820624253



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       Yes, please remove checkpoint-abortion part, and I can accept the PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32461",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32461) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rkhachatryan merged pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18964:
URL: https://github.com/apache/flink/pull/18964


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r820624253



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       Yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r819401856



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       - If a task gets a `CancellationException`, shouldn't it fail the whole job?
   - Why checkpoint abortion notification can pass `CancellationException` to the part of materialization? Materialization should be independent from Checkpointing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9427427e44fc242d820af80833834c28c560cb2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460) 
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18964:
URL: https://github.com/apache/flink/pull/18964#issuecomment-1057523838


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9427427e44fc242d820af80833834c28c560cb2d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32460",
       "triggerID" : "9427427e44fc242d820af80833834c28c560cb2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32461",
       "triggerID" : "43531c4f9e06f8c8b2d3595971161f61ea3008c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43531c4f9e06f8c8b2d3595971161f61ea3008c6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32461) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org