[GitHub] [geode] kirklund commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #5014:
URL: https://github.com/apache/geode/pull/5014#discussion_r419567544



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
##########
@@ -1086,6 +1088,27 @@ public static GemFireCacheImpl getForPdx(String reason) {
     clientMetadataService = clientMetadataServiceFactory.apply(this);
   }
 
+  @Override
+  public void lockDiskStore(String diskStoreName) {
+    CountDownLatch countDownLatch =
+        diskStoreLatches.putIfAbsent(diskStoreName, new CountDownLatch(1));
+    if (countDownLatch != null) {
+      try {
+        countDownLatch.await();

Review comment:
       `putIfAbsent` returns the old value (if any) or null. Are you trying to await() on the old Latch or the new one you just put in the ConcurrentMap?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org