[GitHub] [hudi] xushiyan commented on pull request #6448: [HUDI-4647] Change the default value of HIVE_SYNC_MODE in MergeInto to HMS

[GitBox <gi...@apache.org>]

xushiyan commented on PR #6448:
URL: https://github.com/apache/hudi/pull/6448#issuecomment-1284900637

   > > @dongkelun thanks for the patch. there are 2 reasons to why we have to close this for now:
   > > 
   > > 1. we should keep default value consistent for different scenarios
   > > 2. we don't want to introduce breaking changes (unless with strong reason) until 1.0 when we batch these breakings together
   > > 
   > > hence i'm tracking the tasks here https://issues.apache.org/jira/browse/HUDI-5062
   > > OK. got it
   > > One thing I want to say is that in previous versions of `mergeInto`, the default value of `HIVE_SYNC_MODE` is `HMS`. In other SQL statements, such as `insert` `update`, the default value is also `HMS`
   
   @dongkelun ok in this case it's a different story. we should keep it aligned for all sql scenarios. I'm re-openning this PR. Can you please re-purpose this PR to move `org.apache.spark.sql.hudi.command.MergeIntoHoodieTableCommand#buildMergeIntoConfig` into `org.apache.spark.sql.hudi.ProvidesHoodieConfig`? we should fix the sync mode and make all hive sync settings aligned with others wherever applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org