You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/28 08:47:35 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3956: [ZEPPELIN-5113]. Cursor of code completion is incorrect in some cases

zjffdu opened a new pull request #3956:
URL: https://github.com/apache/zeppelin/pull/3956


   ### What is this PR for?
   
   The cursor of code completion is incorrect in some cases, this cause the code completion broken in some cases.
   
   e.g.
   ```
   %spark.pyspark
   
   spark.
   ```
   
   This PR fix the issue by find the right cursor starting after the interpreter text.
   
   ### What type of PR is it?
   [Bug Fix ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5113
   
   ### How should this be tested?
   * Unit test is added and also manually tested. 
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #3956: [ZEPPELIN-5113]. Cursor of code completion is incorrect in some cases

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3956:
URL: https://github.com/apache/zeppelin/pull/3956


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #3956: [ZEPPELIN-5113]. Cursor of code completion is incorrect in some cases

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3956:
URL: https://github.com/apache/zeppelin/pull/3956#issuecomment-721200870


   Will merge if no more comment


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org