[GitHub] jihoonson closed pull request #5954: Fix bug in SegmentAnalyzer.analyzeComplexColumn() #5939

[GitBox <gi...@apache.org>]

jihoonson closed pull request #5954: Fix bug in SegmentAnalyzer.analyzeComplexColumn() #5939
URL: https://github.com/apache/incubator-druid/pull/5954
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/processing/src/main/java/io/druid/query/metadata/SegmentAnalyzer.java b/processing/src/main/java/io/druid/query/metadata/SegmentAnalyzer.java
index 196bb42cd3b..4153aba1825 100644
--- a/processing/src/main/java/io/druid/query/metadata/SegmentAnalyzer.java
+++ b/processing/src/main/java/io/druid/query/metadata/SegmentAnalyzer.java
@@ -329,7 +329,7 @@ private ColumnAnalysis analyzeComplexColumn(
           return new ColumnAnalysis(typeName, hasMultipleValues, 0, null, null, null, null);
         }
 
-        final int length = column.getLength();
+        final int length = complexColumn.getLength();
         for (int i = 0; i < length; ++i) {
           size += inputSizeFn.apply(complexColumn.getRowValue(i));
         }
diff --git a/processing/src/main/java/io/druid/segment/column/ComplexColumn.java b/processing/src/main/java/io/druid/segment/column/ComplexColumn.java
index 0f5d718bf1c..3956539ccd6 100644
--- a/processing/src/main/java/io/druid/segment/column/ComplexColumn.java
+++ b/processing/src/main/java/io/druid/segment/column/ComplexColumn.java
@@ -33,6 +33,7 @@
   Class<?> getClazz();
   String getTypeName();
   Object getRowValue(int rowNum);
+  int getLength();
 
   @Override
   void close();
diff --git a/processing/src/main/java/io/druid/segment/column/IndexedComplexColumn.java b/processing/src/main/java/io/druid/segment/column/IndexedComplexColumn.java
index daf0eb3a064..0e39d4e6eb9 100644
--- a/processing/src/main/java/io/druid/segment/column/IndexedComplexColumn.java
+++ b/processing/src/main/java/io/druid/segment/column/IndexedComplexColumn.java
@@ -52,6 +52,12 @@ public Object getRowValue(int rowNum)
     return column.get(rowNum);
   }
 
+  @Override
+  public int getLength()
+  {
+    return column.size();
+  }
+
   @Override
   public void close()
   {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org