You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2022/02/04 07:29:50 UTC
[GitHub] [incubator-teaclave] qinkunbao opened a new issue #612: Add shell script style
qinkunbao opened a new issue #612:
URL: https://github.com/apache/incubator-teaclave/issues/612
We should have a style guide for bash scripts.
As discussed in https://github.com/apache/incubator-teaclave/pull/609, environment variables and internal shell variables are capitalized. All other variable names should be lower case. Some shell scripts in the project don't follow this convection.
Here is an example:
https://google.github.io/styleguide/shellguide.html
In addition, we can add a shell scripts format checker to the build pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on issue #612: Add shell script style
Posted by GitBox <gi...@apache.org>.
mssun commented on issue #612:
URL: https://github.com/apache/incubator-teaclave/issues/612#issuecomment-1030254748
The shellcheck will be helpful for the issue: https://github.com/koalaman/shellcheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on issue #612: Add shell script style
Posted by GitBox <gi...@apache.org>.
mssun commented on issue #612:
URL: https://github.com/apache/incubator-teaclave/issues/612#issuecomment-1032965168
Another useful tool `shfmt`: https://github.com/mvdan/sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org