You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/12 10:09:01 UTC
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/423
Fix/fix notebook settings
Setting Window used to be shown inside the notebook and therefore would scroll with notebook content.
In this PR, we are fixing it on top with the NotebookAction bar.
We also have a scrollbar in the settings in case the window height is too small
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/fixNotebookSettings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #423
----
commit 1fde409ae42930b96e4ee49419fa0bae2e87e438
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-12T08:14:38Z
Make settings as fixed position and reduce some space
commit 9e8e46aa88d5ccb12f4b94b7b096357432539948
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-12T08:55:58Z
Add scrollbar to settings if screen too small
commit 3dad90575baa6824d2efd1cccded2d0b5a2757a7
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-12T09:07:15Z
Fix zindex for actionbar tooltips
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156295638
@Leemoonsoo Like this?
<img width="617" alt="screen shot 2015-11-13 at 10 56 37 am" src="https://cloud.githubusercontent.com/assets/710411/11136877/ee97fcac-89f5-11e5-9794-598af4afe460.png">
If it's good I will push that new commit.
However we might want to rethink the layout of those settings later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156288558
Ready To merge
(CI fails on flink, and I would rebase before merge)
I'd love to have a few feedbacks or review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-169187042
I'm still stuck with IE and wasn't able to work on it since.
Since its an improvement its not urgent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156291311
I guess 4/5 in that case would work nicely. I will try and post a screenshot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #423: Fix/fix notebook settings
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/423
Any update on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156290652
I have tested. and working nicely.
One suggestion. How about limit the max-height of setting panel to about 3/4 - 4/5 size of the browser window height? That would clearly indicate user that setting panel is above the notebook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156297071
one small detail is
Isn't it make more sense to move shadow to the bottom of the setting panel, when it is expanded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156336725
I'm trying to play with flexbox to get this result
<img width="547" alt="screen shot 2015-11-13 at 12 03 35 pm" src="https://cloud.githubusercontent.com/assets/710411/11140052/822a21e8-8a19-11e5-9385-ff930943e005.png">
But it's not working on IE with max-height... so I'm trying to find a way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-156296293
Yes, that's what i thought.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix/fix notebook settings
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/423#issuecomment-168945026
Looks great.
@corneadoug did you manage to find a way to do it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---