You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by Christofer Dutz <ch...@c-ware.de> on 2015/10/06 11:07:48 UTC
Add fix from the Apache Flex project?
Hi,
I am currently cleaning up a real messy build we inherited from Adobe. Part of this build builds a "patched" version of xerces, that seems to fix some problems they were having:
A patch for Apache Xerces 2.9.1 to retain line number information
for XML tag attributes that may extend onto multiple lines.
So I thought it might have been Adobe's way of dealing with things, the proper way however to have this sorted out would be to actually have this fixed in the original project.
If you could please have a look at this:
https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch
[https://avatars1.githubusercontent.com/u/47359?v=3&s=400]<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk · GitHub
flex-sdk - Mirror of Apache Flex SDK
Weitere Informationen...<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
I would be glad to be of assistance in sorting out any problems.
Chris
AW: AW: Add fix from the Apache Flex project?
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok ... thanks for the "help" and the enlightening "discussion" ... we'll just continue shipping hacked stone-aged versions of xerces.
Chris
-----Ursprüngliche Nachricht-----
Von: Christofer Dutz [mailto:christofer.dutz@c-ware.de]
Gesendet: Freitag, 6. November 2015 07:41
An: j-dev@xerces.apache.org
Betreff: AW: AW: Add fix from the Apache Flex project?
That was why I initially asked on this list, if there has been a fix in the project itself. As far as I understood the main problem, in case of a multi-line element they wanted to be informed about the exact line of the invalid content and not only about the row the element starts. They need this for error highlighing in the DIE. So if this issue has been addressed in future XAlan releases, I would be glad to switch to that.
Chris
-----Ursprüngliche Nachricht-----
Von: Michael Glavassevich [mailto:mrglavas@ca.ibm.com]
Gesendet: Donnerstag, 5. November 2015 23:01
An: j-dev@xerces.apache.org
Betreff: Re: AW: Add fix from the Apache Flex project?
This isn't really a "fix". Looks like they hacked in a custom feature that they needed for some reason. There's probably a cleaner way of implementing it internally, but worth pointing out that line/column information of attributes isn't something a user is going to be able to access from the standard JAXP APIs.
Michael Glavassevich
XML Technologies and WAS Development
IBM Toronto Lab
E-mail: mrglavas@ca.ibm.com
E-mail: mrglavas@apache.org
Christofer Dutz <ch...@c-ware.de> wrote on 10/06/2015 06:07:54
AM:
> Ok so they seem to have actually only adjusted 3 classes:
> org.apache.xerces.util.XMLAttributesImpl which they call
XMLAttributesMMImpl
> org.apache.xerces.impl.XML11DocumentScannerImpl which they call
> XMLDocumentScannerMMImpl and
> org.apache.xerces.impl.XMLDocumentScannerImpl which they call
> XMLNSDocumentScannerMMImpl All other changes simply only have the
> purpose of using the changed classes instead of the original ones.
>
> The changes in these classes however seem quite significant ... so I'd
> be really happy to hear that newer versions of xalan have addressed
> the "problem" Adobe (but judging from the MM insertion it was probably
> even Macromedia) was having.
>
> Chris
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:52
> An: j-dev@xerces.apache.org
> Betreff: AW: Add fix from the Apache Flex project?
>
> I'm currently trying to whip up a patch file so you can see what they
> thought needed changing ... hopefully this has been already fixed in a
> newer version and I/we don't have to do anything but update to a more
> recent version.
>
> Chris
>
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:07
> An: j-dev@xerces.apache.org
> Betreff: Add fix from the Apache Flex project?
>
> Hi,
>
> I am currently cleaning up a real messy build we inherited from Adobe.
> Part of this build builds a "patched" version of xerces, that seems to
> fix some problems they were having:
>
> A patch for Apache Xerces 2.9.1 to retain line number information for
> XML tag attributes that may extend onto multiple lines.
>
> So I thought it might have been Adobe's way of dealing with things,
> the proper way however to have this sorted out would be to actually
> have this fixed in the original project.
>
> If you could please have a look at this:
> https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/
> xerces-patch
>
> [image removed]
>
> flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk
> ·
GitHub
> flex-sdk - Mirror of Apache Flex SDK
> Weitere Informationen...
>
>
>
> I would be glad to be of assistance in sorting out any problems.
>
> Chris
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
AW: AW: Add fix from the Apache Flex project?
Posted by Christofer Dutz <ch...@c-ware.de>.
That was why I initially asked on this list, if there has been a fix in the project itself. As far as I understood the main problem, in case of a multi-line element they wanted to be informed about the exact line of the invalid content and not only about the row the element starts. They need this for error highlighing in the DIE. So if this issue has been addressed in future XAlan releases, I would be glad to switch to that.
Chris
-----Ursprüngliche Nachricht-----
Von: Michael Glavassevich [mailto:mrglavas@ca.ibm.com]
Gesendet: Donnerstag, 5. November 2015 23:01
An: j-dev@xerces.apache.org
Betreff: Re: AW: Add fix from the Apache Flex project?
This isn't really a "fix". Looks like they hacked in a custom feature that they needed for some reason. There's probably a cleaner way of implementing it internally, but worth pointing out that line/column information of attributes isn't something a user is going to be able to access from the standard JAXP APIs.
Michael Glavassevich
XML Technologies and WAS Development
IBM Toronto Lab
E-mail: mrglavas@ca.ibm.com
E-mail: mrglavas@apache.org
Christofer Dutz <ch...@c-ware.de> wrote on 10/06/2015 06:07:54
AM:
> Ok so they seem to have actually only adjusted 3 classes:
> org.apache.xerces.util.XMLAttributesImpl which they call
XMLAttributesMMImpl
> org.apache.xerces.impl.XML11DocumentScannerImpl which they call
> XMLDocumentScannerMMImpl and
> org.apache.xerces.impl.XMLDocumentScannerImpl which they call
> XMLNSDocumentScannerMMImpl All other changes simply only have the
> purpose of using the changed classes instead of the original ones.
>
> The changes in these classes however seem quite significant ... so I'd
> be really happy to hear that newer versions of xalan have addressed
> the "problem" Adobe (but judging from the MM insertion it was probably
> even Macromedia) was having.
>
> Chris
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:52
> An: j-dev@xerces.apache.org
> Betreff: AW: Add fix from the Apache Flex project?
>
> I'm currently trying to whip up a patch file so you can see what they
> thought needed changing ... hopefully this has been already fixed in a
> newer version and I/we don't have to do anything but update to a more
> recent version.
>
> Chris
>
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:07
> An: j-dev@xerces.apache.org
> Betreff: Add fix from the Apache Flex project?
>
> Hi,
>
> I am currently cleaning up a real messy build we inherited from Adobe.
> Part of this build builds a "patched" version of xerces, that seems to
> fix some problems they were having:
>
> A patch for Apache Xerces 2.9.1 to retain line number information for
> XML tag attributes that may extend onto multiple lines.
>
> So I thought it might have been Adobe's way of dealing with things,
> the proper way however to have this sorted out would be to actually
> have this fixed in the original project.
>
> If you could please have a look at this:
> https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/
> xerces-patch
>
> [image removed]
>
> flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk
> ·
GitHub
> flex-sdk - Mirror of Apache Flex SDK
> Weitere Informationen...
>
>
>
> I would be glad to be of assistance in sorting out any problems.
>
> Chris
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: AW: Add fix from the Apache Flex project?
Posted by Michael Glavassevich <mr...@ca.ibm.com>.
This isn't really a "fix". Looks like they hacked in a custom feature that
they needed for some reason. There's probably a cleaner way of
implementing it internally, but worth pointing out that line/column
information of attributes isn't something a user is going to be able to
access from the standard JAXP APIs.
Michael Glavassevich
XML Technologies and WAS Development
IBM Toronto Lab
E-mail: mrglavas@ca.ibm.com
E-mail: mrglavas@apache.org
Christofer Dutz <ch...@c-ware.de> wrote on 10/06/2015 06:07:54
AM:
> Ok so they seem to have actually only adjusted 3 classes:
> org.apache.xerces.util.XMLAttributesImpl which they call
XMLAttributesMMImpl
> org.apache.xerces.impl.XML11DocumentScannerImpl which they call
> XMLDocumentScannerMMImpl
> and
> org.apache.xerces.impl.XMLDocumentScannerImpl which they call
> XMLNSDocumentScannerMMImpl
> All other changes simply only have the purpose of using the changed
> classes instead of the original ones.
>
> The changes in these classes however seem quite significant ... so
> I'd be really happy to hear that newer versions of xalan have
> addressed the "problem" Adobe (but judging from the MM insertion it
> was probably even Macromedia) was having.
>
> Chris
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:52
> An: j-dev@xerces.apache.org
> Betreff: AW: Add fix from the Apache Flex project?
>
> I'm currently trying to whip up a patch file so you can see what
> they thought needed changing ... hopefully this has been already
> fixed in a newer version and I/we don't have to do anything but
> update to a more recent version.
>
> Chris
>
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Dienstag, 6. Oktober 2015 11:07
> An: j-dev@xerces.apache.org
> Betreff: Add fix from the Apache Flex project?
>
> Hi,
>
> I am currently cleaning up a real messy build we inherited from
> Adobe. Part of this build builds a "patched" version of xerces, that
> seems to fix some problems they were having:
>
> A patch for Apache Xerces 2.9.1 to retain line number information
> for XML tag attributes that may extend onto multiple lines.
>
> So I thought it might have been Adobe's way of dealing with things,
> the proper way however to have this sorted out would be to actually
> have this fixed in the original project.
>
> If you could please have a look at this:
> https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/
> xerces-patch
>
> [image removed]
>
> flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk ·
GitHub
> flex-sdk - Mirror of Apache Flex SDK
> Weitere Informationen...
>
>
>
> I would be glad to be of assistance in sorting out any problems.
>
> Chris
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
AW: Add fix from the Apache Flex project?
Posted by Christofer Dutz <ch...@c-ware.de>.
PING?
... is this a dead list?
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 12:07
An: j-dev@xerces.apache.org
Betreff: AW: Add fix from the Apache Flex project?
Ok so they seem to have actually only adjusted 3 classes:
org.apache.xerces.util.XMLAttributesImpl which they call XMLAttributesMMImpl
org.apache.xerces.impl.XML11DocumentScannerImpl which they call XMLDocumentScannerMMImpl
and
org.apache.xerces.impl.XMLDocumentScannerImpl which they call XMLNSDocumentScannerMMImpl
All other changes simply only have the purpose of using the changed classes instead of the original ones.
The changes in these classes however seem quite significant ... so I'd be really happy to hear that newer versions of xalan have addressed the "problem" Adobe (but judging from the MM insertion it was probably even Macromedia) was having.
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 11:52
An: j-dev@xerces.apache.org
Betreff: AW: Add fix from the Apache Flex project?
I'm currently trying to whip up a patch file so you can see what they thought needed changing ... hopefully this has been already fixed in a newer version and I/we don't have to do anything but update to a more recent version.
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 11:07
An: j-dev@xerces.apache.org
Betreff: Add fix from the Apache Flex project?
Hi,
I am currently cleaning up a real messy build we inherited from Adobe. Part of this build builds a "patched" version of xerces, that seems to fix some problems they were having:
A patch for Apache Xerces 2.9.1 to retain line number information
for XML tag attributes that may extend onto multiple lines.
So I thought it might have been Adobe's way of dealing with things, the proper way however to have this sorted out would be to actually have this fixed in the original project.
If you could please have a look at this:
https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch
[https://avatars1.githubusercontent.com/u/47359?v=3&s=400]<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk · GitHub
flex-sdk - Mirror of Apache Flex SDK
Weitere Informationen...<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
I would be glad to be of assistance in sorting out any problems.
Chris
AW: Add fix from the Apache Flex project?
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok so they seem to have actually only adjusted 3 classes:
org.apache.xerces.util.XMLAttributesImpl which they call XMLAttributesMMImpl
org.apache.xerces.impl.XML11DocumentScannerImpl which they call XMLDocumentScannerMMImpl
and
org.apache.xerces.impl.XMLDocumentScannerImpl which they call XMLNSDocumentScannerMMImpl
All other changes simply only have the purpose of using the changed classes instead of the original ones.
The changes in these classes however seem quite significant ... so I'd be really happy to hear that newer versions of xalan have addressed the "problem" Adobe (but judging from the MM insertion it was probably even Macromedia) was having.
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 11:52
An: j-dev@xerces.apache.org
Betreff: AW: Add fix from the Apache Flex project?
I'm currently trying to whip up a patch file so you can see what they thought needed changing ... hopefully this has been already fixed in a newer version and I/we don't have to do anything but update to a more recent version.
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 11:07
An: j-dev@xerces.apache.org
Betreff: Add fix from the Apache Flex project?
Hi,
I am currently cleaning up a real messy build we inherited from Adobe. Part of this build builds a "patched" version of xerces, that seems to fix some problems they were having:
A patch for Apache Xerces 2.9.1 to retain line number information
for XML tag attributes that may extend onto multiple lines.
So I thought it might have been Adobe's way of dealing with things, the proper way however to have this sorted out would be to actually have this fixed in the original project.
If you could please have a look at this:
https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch
[https://avatars1.githubusercontent.com/u/47359?v=3&s=400]<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk · GitHub
flex-sdk - Mirror of Apache Flex SDK
Weitere Informationen...<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
I would be glad to be of assistance in sorting out any problems.
Chris
AW: Add fix from the Apache Flex project?
Posted by Christofer Dutz <ch...@c-ware.de>.
I'm currently trying to whip up a patch file so you can see what they thought needed changing ... hopefully this has been already fixed in a newer version and I/we don't have to do anything but update to a more recent version.
Chris
________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Dienstag, 6. Oktober 2015 11:07
An: j-dev@xerces.apache.org
Betreff: Add fix from the Apache Flex project?
Hi,
I am currently cleaning up a real messy build we inherited from Adobe. Part of this build builds a "patched" version of xerces, that seems to fix some problems they were having:
A patch for Apache Xerces 2.9.1 to retain line number information
for XML tag attributes that may extend onto multiple lines.
So I thought it might have been Adobe's way of dealing with things, the proper way however to have this sorted out would be to actually have this fixed in the original project.
If you could please have a look at this:
https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch
[https://avatars1.githubusercontent.com/u/47359?v=3&s=400]<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
flex-sdk/modules/thirdparty/xerces-patch at develop · apache/flex-sdk · GitHub
flex-sdk - Mirror of Apache Flex SDK
Weitere Informationen...<https://github.com/apache/flex-sdk/tree/develop/modules/thirdparty/xerces-patch>
I would be glad to be of assistance in sorting out any problems.
Chris