You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Shreepadma Venugopalan <sh...@apache.org> on 2013/10/02 21:21:46 UTC
RAT checks
RAT checks are invoked in the verify phase and are not run during a 'mvn
package' command. To run RAT checks, need to do 'mvn verify -DskipTests'.
Alternately, a later phase such as 'mvn install' can also be used. Please
remember to do this before you submit a patch as well as before committing.
Thanks.
Shreepadma
Re: RAT checks
Posted by Shreepadma Venugopalan <sh...@apache.org>.
I'm OK with moving it to a different phase such as test. Any objections?
On Wed, Oct 2, 2013 at 12:33 PM, Prasad Mujumdar <pr...@cloudera.com>wrote:
> Hi Shreepadma,
>
> Thanks for the feedback.
> IMO, it would still be easy to miss that in future. Perhaps we should
> execute the RAT plugin in test phase. I agree that its important to catch
> this upfront and not on the RC vote for next release :)
>
> thanks
> Prasad
>
>
>
> On Wed, Oct 2, 2013 at 12:21 PM, Shreepadma Venugopalan <
> shreepadma@apache.org> wrote:
>
> > RAT checks are invoked in the verify phase and are not run during a 'mvn
> > package' command. To run RAT checks, need to do 'mvn verify -DskipTests'.
> > Alternately, a later phase such as 'mvn install' can also be used. Please
> > remember to do this before you submit a patch as well as before
> committing.
> >
> > Thanks.
> > Shreepadma
> >
>
Re: RAT checks
Posted by Prasad Mujumdar <pr...@cloudera.com>.
Hi Shreepadma,
Thanks for the feedback.
IMO, it would still be easy to miss that in future. Perhaps we should
execute the RAT plugin in test phase. I agree that its important to catch
this upfront and not on the RC vote for next release :)
thanks
Prasad
On Wed, Oct 2, 2013 at 12:21 PM, Shreepadma Venugopalan <
shreepadma@apache.org> wrote:
> RAT checks are invoked in the verify phase and are not run during a 'mvn
> package' command. To run RAT checks, need to do 'mvn verify -DskipTests'.
> Alternately, a later phase such as 'mvn install' can also be used. Please
> remember to do this before you submit a patch as well as before committing.
>
> Thanks.
> Shreepadma
>