You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/04 18:38:03 UTC

[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3627: Update EventMeshConsumer.java

harshithasudhakar opened a new pull request, #3627:
URL: https://github.com/apache/eventmesh/pull/3627

   [Fixes #3165] "Actual value of parameter 'defaultValue' is always"
   
   ### Motivation
   
   Since the 'defaultValue' variable is going to be empty throughout. Hence, there is no requirement of a third parameter.
   
   ### Modifications
   
   Removed the parameter 'defaultValue' at line 256. Replaced 'defaultvalue' with "" at line 258 . I have also removed the third parameter at lines 196 and 197.
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
     No
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     Not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] xwm1992 merged pull request #3627: [ISSUE #3165]Actual value of parameter 'defaultValue' is always"

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3627:
URL: https://github.com/apache/eventmesh/pull/3627


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] codecov[bot] commented on pull request #3627: [ISSUE #3165]Actual value of parameter 'defaultValue' is always"

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3627:
URL: https://github.com/apache/eventmesh/pull/3627#issuecomment-1498406471

   ## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3627](https://codecov.io/gh/apache/eventmesh/pull/3627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49861b7) into [master](https://codecov.io/gh/apache/eventmesh/commit/4eb819f6938749b0e22c54dc905f9d055589cb37?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eb819f) will **decrease** coverage by `0.02%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 49861b7 differs from pull request most recent head 19ffa83. Consider uploading reports for the commit 19ffa83 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3627      +/-   ##
   ============================================
   - Coverage     13.76%   13.75%   -0.02%     
     Complexity     1291     1291              
   ============================================
     Files           571      571              
     Lines         29239    29232       -7     
     Branches       2885     2873      -12     
   ============================================
   - Hits           4024     4020       -4     
   + Misses        24841    24839       -2     
   + Partials        374      373       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...core/protocol/http/consumer/EventMeshConsumer.java](https://codecov.io/gh/apache/eventmesh/pull/3627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
   
   ... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3627/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org