You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/23 17:36:26 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #6025: [Docs] Update migrate behaviour with respect to drop_table in spark-procedures docs.
rdblue commented on code in PR #6025:
URL: https://github.com/apache/iceberg/pull/6025#discussion_r1002744138
##########
docs/spark-procedures.md:
##########
@@ -421,12 +421,18 @@ Existing data files are added to the Iceberg table's metadata and can be read us
To leave the original table intact while testing, use [`snapshot`](#snapshot) to create new temporary table that shares source data files and schema.
+Migrate will create a backup table with name [`table__BACKUP__`]. If you feel confident that the migration succeeded
+feel free to drop the backup table. You can also explicitly pass [`drop_backup => true`] to drop the backup table after
+migration finishes.
+
#### Usage
-| Argument Name | Required? | Type | Description |
-|---------------|-----------|------|-------------|
-| `table` | ✔️ | string | Name of the table to migrate |
-| `properties` | ️ | map<string, string> | Properties for the new Iceberg table |
+| Argument Name | Required? | Type | Description |
+|---------------|---------|------|--------------------------------------------------------------------------------------|
+| `table` | ✔️ | string | Name of the table to migrate |
+| `properties` | ️ | map<string, string> | Properties for the new Iceberg table |
Review Comment:
Can you revert the changes to the other lines? I don't think these were updated so there is no need to modify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org