[GitHub] [beam] mosche commented on pull request #26320: Select dedicated avro datum reader and writer

["mosche (via GitHub)" <gi...@apache.org>]

mosche commented on PR #26320:
URL: https://github.com/apache/beam/pull/26320#issuecomment-1563117367

   Thanks a lot for this @RustedBones!
   And thanks for the ping @aromanenko-dev, totally missed this.
   
   As @aromanenko-dev already pointed out, backwards compatibility is a concern here. Most of my initial comments are on that. The thing I'm mostly worried about is that this seems to change the behavior by removing the default logical conversion for Joda `DateTime`. With Beam still relying heavily on Joda, this will break users badly unless I misunderstand.
   
   Also note, looks like some tests are failing:
   ```
   gradle :sdks:java:extensions:avro:avroVersionsTest
   ```
   
   Also make sure to rebase onto master, `@Experimental` was recently removed from Beam... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org