You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/22 20:16:23 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #9460: Data-iterator tutorial made python3 compatible.

eric-haibin-lin commented on a change in pull request #9460: Data-iterator tutorial made python3 compatible.
URL: https://github.com/apache/incubator-mxnet/pull/9460#discussion_r163056058
 
 

 ##########
 File path: docs/tutorials/basic/data.md
 ##########
 @@ -122,17 +126,17 @@ class SimpleIter(mx.io.DataIter):
 
     @property
     def provide_data(self):
-        return self._provide_data
+        return zip(self._data_names, self._data_shapes)
 
     @property
     def provide_label(self):
-        return self._provide_label
+        return zip(self._label_names, self._label_shapes)
 
 Review comment:
   Isn't this already done in `__init__`? 
   `self._provide_data = zip(data_names, data_shapes)` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services