[GitHub] [arrow-datafusion] alamb commented on issue #6405: Move tpch tests into sqllogictest.

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on issue #6405:
URL: https://github.com/apache/arrow-datafusion/issues/6405#issuecomment-1572547631

   > I think the complexity of comparing is caused by text plan representation. As with fixing the change part, you can run --complete mode, which will fix slt result automatically.
   
   I agree with @liurenjie1024  that it is the textual representation that makes comparison hard, not the .slt files.
   
   @mingmwang  one of the big benefits in my mind to `slt` files is that they are easy to update. 
   
   For example, you could create the change in  https://github.com/apache/arrow-datafusion/commit/a752ee8f351a51606260e37fc8e781ffec3ff74b by running 
   
   ```shell
   cargo test -p datafusion --test sqllogictest -- tpch --complete
   ```
   And then you can review the changes and check them in
   
   
   (Complete docs are in  https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/README.md)
   
   Does that work for you? If not, is there something that would make it easier for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org