You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 13:43:09 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3853: Enable mimalloc by default in benchmark

alamb commented on code in PR #3853:
URL: https://github.com/apache/arrow-datafusion/pull/3853#discussion_r998248909


##########
benchmarks/Cargo.toml:
##########
@@ -28,6 +28,7 @@ publish = false
 rust-version = "1.62"
 
 [features]
+default = ["mimalloc"]

Review Comment:
   ```
   alamb@MacBook-Pro-8 arrow-datafusion2 % find . -name '*.toml' | xargs grep -r mimalloc
   find . -name '*.toml' | xargs grep -r mimalloc
   ./datafusion-cli/Cargo.toml:mimalloc = { version = "0.1", default-features = false }
   ./benchmarks/Cargo.toml:mimalloc = { version = "0.1", optional = true, default-features = false }
   ```
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org