You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:37:20 UTC
[GitHub] [airflow] kaxil opened a new pull request #7349: [AIRFLOW-6725]
Simplify chaining operation in DagFileProcessorManager
kaxil opened a new pull request #7349: [AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7349
Simplify chaining operation in an IF condition
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7349: [AIRFLOW-6725] Simplify
chaining operation in DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7349: [AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7349: [AIRFLOW-6725]
Simplify chaining operation in DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7349: [AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7349#issuecomment-581470260
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=h1) Report
> Merging [#7349](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/eb0f6d1b2c317088ee261aa10caa6df783fb8652?src=pr&el=desc) will **decrease** coverage by `54.26%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7349 +/- ##
===========================================
- Coverage 86.35% 32.09% -54.27%
===========================================
Files 871 870 -1
Lines 40613 40600 -13
===========================================
- Hits 35073 13030 -22043
- Misses 5540 27570 +22030
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `24.71% <0%> (-63.41%)` | :arrow_down: |
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...ing\_platform/example\_dags/example\_display\_video.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL21hcmtldGluZ19wbGF0Zm9ybS9leGFtcGxlX2RhZ3MvZXhhbXBsZV9kaXNwbGF5X3ZpZGVvLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [741 more](https://codecov.io/gh/apache/airflow/pull/7349/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=footer). Last update [eb0f6d1...4d2665a](https://codecov.io/gh/apache/airflow/pull/7349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7349: [AIRFLOW-6725] Simplify
chaining operation in DagFileProcessorManager
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7349: [AIRFLOW-6725] Simplify chaining operation in DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7349#issuecomment-581473717
> I accept it. But what will we do to prevent regression so that similar problems do not arise in the future? Cosmetic changes should be detected automatically because the OOS community cannot force rules otherwise.
**chained-comparison** - This **pylint** rule should, in theory, take care of this.(https://github.com/PyCQA/pylint/pull/2046)
Need to dig in more detail on why it didn't check this, maybe the file is still not pylint compatible and hence in **ignored!** list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services