[GitHub] [ambari-metrics] kevinw66 commented on a diff in pull request #48: AMBARI-25320 Backport AMBARI-24872 and AMBARI-24723 for ambari 2.7.4

[GitBox <gi...@apache.org>]

kevinw66 commented on code in PR #48:
URL: https://github.com/apache/ambari-metrics/pull/48#discussion_r1003938194


##########
ambari-metrics-grafana/ambari-metrics/datasource.js:
##########
@@ -292,8 +292,8 @@ define([
         var getAllHostData = function (target) {
           var instanceId = typeof target.templatedCluster == 'undefined' ? '' : '&instanceId=' + target.templatedCluster;
           var appId = target.app;
-          if ((appId === 'nifi' || appId === 'druid') && !instanceId) {
-            instanceId = "%"
+          if ((appId === 'nifi' || appId === 'druid') && (!instanceId || instanceId === '&instanceId=')) {
+                instanceId = "&instanceId=%"

Review Comment:
   Please use correct indent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org