You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by shen guoquan <gu...@intel.com> on 2015/03/06 07:35:53 UTC
Re: Review Request 31070: Sentry-656: Update SentryStore for
import/export feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31070/#review75467
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
<https://reviews.apache.org/r/31070/#comment122529>
Currently the order to get all mapping data for [role, privilege] is at firstly to get all privileges, then according to each privilege to get roles. I think the privilges are much more than roles in the database, why not reserve the order. At firstly to get all roles, then privileges
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
<https://reviews.apache.org/r/31070/#comment122527>
Redundant whitesapces
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
<https://reviews.apache.org/r/31070/#comment122528>
Above situation
- shen guoquan
On 二月 17, 2015, 1:15 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31070/
> -----------------------------------------------------------
>
> (Updated 二月 17, 2015, 1:15 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update SentryStore for import/export feature
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 136dab6
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31070/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 31070: Sentry-656: Update SentryStore for
import/export feature
Posted by Colin Ma <ju...@intel.com>.
> On March 6, 2015, 6:35 a.m., shen guoquan wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, line 2002
> > <https://reviews.apache.org/r/31070/diff/2/?file=865318#file865318line2002>
> >
> > Currently the order to get all mapping data for [role, privilege] is at firstly to get all privileges, then according to each privilege to get roles. I think the privilges are much more than roles in the database, why not reserve the order. At firstly to get all roles, then privileges
good point, I'll update the logic for this part.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31070/#review75467
-----------------------------------------------------------
On Feb. 17, 2015, 1:15 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31070/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 1:15 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update SentryStore for import/export feature
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 136dab6
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31070/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>