You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by "Mike Percy (JIRA)" <ji...@apache.org> on 2013/02/26 23:16:15 UTC

[jira] [Commented] (FLUME-1922) HDFS Sink should optionally insert the timestamp at the sink

    [ https://issues.apache.org/jira/browse/FLUME-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587650#comment-13587650 ] 

Mike Percy commented on FLUME-1922:
-----------------------------------

Patch looks good to me. I agree we need this features. Couple of comments:
1. Needs user doc
2. Can you please add a comment to HDFSEventSink.setBucketClock() indicating that it calls a static method and should only be used by tests? Or just add a @VisibleForTesting annotation to that method too.

Thanks!
                
> HDFS Sink should optionally insert the timestamp at the sink
> ------------------------------------------------------------
>
>                 Key: FLUME-1922
>                 URL: https://issues.apache.org/jira/browse/FLUME-1922
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-1922.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira