Re: [PR] [SPARK-53492][CONNECT] Reject second ExecutePlan with an operation id that has already completed [spark]

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #52232:
URL: https://github.com/apache/spark/pull/52232#discussion_r2325498918


##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala:
##########
@@ -93,6 +93,10 @@ case class SessionHolder(userId: String, sessionId: String, session: SparkSessio
   // Setting it to -1 indicated forever.
   @volatile private var customInactiveTimeoutMs: Option[Long] = None
 
+  // Mapping from operation ID to a boolean indicating whether the operation is complete.
+  // Used to track the status of operations in the session.
+  // The boolean is true if the operation is active, false if the operation has completed
+  // execution.
   private val operationIds: ConcurrentMap[String, Boolean] =

Review Comment:
   Should we at some point clean this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org