You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/01 12:22:26 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533368080
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java
##########
@@ -221,7 +222,7 @@ public static ExecutionGraph buildGraph(
vertex.initializeOnMaster(classLoader);
}
catch (Throwable t) {
- throw new JobExecutionException(jobId,
+ throw new JobExecutionException(jobId, ApplicationStatus.fromJobStatus(executionGraph.getState()),
Review comment:
One problem is that we are specifying the "final" application status for the `JobExecutionException` here. I think this is wrong since `executionGraph.getState()` could also be something different than a globally terminal state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org