You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2010/06/04 16:39:34 UTC

Re: svn commit: r951093 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ coyote/ajp/ coyote/http11/

2010/6/3  <ma...@apache.org>:
> Author: markt
> Date: Thu Jun  3 18:13:47 2010
> New Revision: 951093
>
> URL: http://svn.apache.org/viewvc?rev=951093&view=rev
> Log:
> Extend access logging to requests rejected in the Processors
>
> Modified:
>    tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

> --- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Thu Jun  3 18:13:47 2010
> @@ -457,6 +457,41 @@ public class CoyoteAdapter implements Ad
>     }
>
>
> +    public void log(org.apache.coyote.Request req,
> +            org.apache.coyote.Response res, long time) {
> +
(...)
> +        connector.getService().getContainer().logAccess(
> +                request, response, 0, true);

The "time" argument was not used. Though if its value is always zero
then nobody will notice the difference.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r951093 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ coyote/ajp/ coyote/http11/

Posted by Mark Thomas <ma...@apache.org>.
On 04/06/2010 15:39, Konstantin Kolinko wrote:
> 2010/6/3  <ma...@apache.org>:
>> Author: markt
>> Date: Thu Jun  3 18:13:47 2010
>> New Revision: 951093
>>
>> URL: http://svn.apache.org/viewvc?rev=951093&view=rev
>> Log:
>> Extend access logging to requests rejected in the Processors
>>
>> Modified:
>>    tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
> 
>> --- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java (original)
>> +++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Thu Jun  3 18:13:47 2010
>> @@ -457,6 +457,41 @@ public class CoyoteAdapter implements Ad
>>     }
>>
>>
>> +    public void log(org.apache.coyote.Request req,
>> +            org.apache.coyote.Response res, long time) {
>> +
> (...)
>> +        connector.getService().getContainer().logAccess(
>> +                request, response, 0, true);
> 
> The "time" argument was not used. Though if its value is always zero
> then nobody will notice the difference.

It isn't used but in case it ever is, I'll fix that.

Cheers.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org