You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/12 19:10:13 UTC

[GitHub] [phoenix-queryserver] joshelser commented on a change in pull request #20: PHOENIX-5772 Streamline the kerberos logic in thin client java code

joshelser commented on a change in pull request #20: PHOENIX-5772 Streamline the kerberos logic in thin client java code
URL: https://github.com/apache/phoenix-queryserver/pull/20#discussion_r391831456
 
 

 ##########
 File path: bin/thin_client_jaas.conf
 ##########
 @@ -0,0 +1,5 @@
+ThinClient {
 
 Review comment:
   Maybe make this PhoenixThinClient? Disambiguate from other products who have JAAS config names.
   
   e.g. ZooKeeper uses a generic name like "Client" or something equally annoying and likely to conflict with other systems :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services