[GitHub] [airflow] mik-laj commented on a change in pull request #11726: Add DataflowJobStatusSensor and support non-blocking execution of jobs

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #11726:
URL: https://github.com/apache/airflow/pull/11726#discussion_r510455340



##########
File path: airflow/providers/google/cloud/operators/dataflow.py
##########
@@ -132,6 +132,15 @@ class DataflowCreateJavaJobOperator(BaseOperator):
     :type check_if_running: CheckJobRunning(IgnoreJob = do not check if running, FinishIfRunning=
         if job is running finish with nothing, WaitForRun= wait until job finished and the run job)
         ``jar``, ``options``, and ``job_name`` are templated so you can use variables in them.
+    :param wait_until_finished: (Optional)

Review comment:
       You made the description a bit complicated.
   
   ```
   If True, wait for the end of pipeline execution before exiting. If False, it only waits for it to starts (``JOB_STATE_RUNNING``).
   
   The default behavior  depends on the type of pipeline:
   * for the streaming pipeline, wait for jobs to start,
   * for the batch pipeline, wait for the jobs to complete.
   
   .. warning::
   
       You cannot call ``PipelineResult.wait_until_finish`` method in your pipeline code for the operator to work properly. i. e. you must use asynchronous execution. Otherwise, your pipeline will always wait until finished. For more information, look at: `Asynchronous execution <https://cloud.google.com/dataflow/docs/guides/specifying-exec-params#python_10>`__
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org