[GitHub] [incubator-mxnet] DickJC123 opened a new pull request #15056: GPU RNN to use TempSpace resource for workspace.

[GitBox <gi...@apache.org>]

DickJC123 opened a new pull request #15056: GPU RNN to use TempSpace resource for workspace.
URL: https://github.com/apache/incubator-mxnet/pull/15056
 
 
   ## Description ##
   This PR eliminates the test flakiness described in https://github.com/apache/incubator-mxnet/issues/15034 (non-deterministic low-probability test_operator_gpu.py:test_rnntanh_bidirectional failures on P40)
   
   The fix was to move the cudnn workspace from a per-op-instance permanent allocation to use the shared TempSpace resource.  Note that for temporary additional workspace, operators typically request space from the shared global TempSpace resource that is maintained for each gpu worker.  This was in fact the approach taken by cudnn_rnn-inl.h before it was combined with rnn-inl.h by  https://github.com/apache/incubator-mxnet/pull/14476.  So in a sense, this PR simply reverts the portion of the 14476 PR that correlates with the flakiness, a much better result than having to revert the entire PR.
   
   Some minor code cleanup was performed around now-unused RNNOp data members `dropout_states_` and `dropout_bytes_`.
    
   @shza @lihaofd @ptrendx 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ X ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ X ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services