You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtadepalli (via GitHub)" <gi...@apache.org> on 2023/02/26 21:51:58 UTC
[GitHub] [arrow] rtadepalli opened a new pull request, #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
rtadepalli opened a new pull request, #34357:
URL: https://github.com/apache/arrow/pull/34357
### Rationale for this change
Today, the `FlightServer` is created in `FlightTestUtil#getStartedServer`. All tests that need a server go through this function, but this is unnecessary since the server could directly be started on port 0 (the OS will assign a random port later).
### What changes are included in this PR?
All invocations of `FlightTestUtil#getStartedServer` have been removed, and the burden of generating a `Location` object for the server has been placed on the caller.
### Are these changes tested?
Existing tests impacted were run locally to make sure that there no regressions.
### Are there any user-facing changes?
There are no user facing changes. There are no breaking changes to the public API as well.
@lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34357:
URL: https://github.com/apache/arrow/pull/34357#issuecomment-1445476852
* Closes: #32954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34357:
URL: https://github.com/apache/arrow/pull/34357#issuecomment-1447129889
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cc0d3e5e476148ff8ad72af2a31fe8eb...4b9863e6fbac43639301500c4e5d930d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34357:
URL: https://github.com/apache/arrow/pull/34357#issuecomment-1445476859
:warning: GitHub issue #32954 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #34357:
URL: https://github.com/apache/arrow/pull/34357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34357: GH-32954: [Java][FlightRPC] Remove FlightTestUtil#getStartedServer and bind to port 0 directly
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34357:
URL: https://github.com/apache/arrow/pull/34357#issuecomment-1447127921
Benchmark runs are scheduled for baseline = 7e248b10b428ad1275045b229323672afba6c5e4 and contender = 06f28d206ed5ec60750e353d99062f83e47cd0a7. 06f28d206ed5ec60750e353d99062f83e47cd0a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/24ec9053198f45e1ac4002ca02432a3f...0312836ff28649fea770451ad11688f0/)
[Finished :arrow_down:1.22% :arrow_up:0.83%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4a1908e927fb45db9e0d3635ae6b32e7...4a18a59960b444e29856168efed7235c/)
[Finished :arrow_down:2.04% :arrow_up:2.3%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cc0d3e5e476148ff8ad72af2a31fe8eb...4b9863e6fbac43639301500c4e5d930d/)
[Finished :arrow_down:0.22% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8918b2a2cb0d42b3b883c860076197b2...7b810a7440b64dd99021440515c8a487/)
Buildkite builds:
[Finished] [`06f28d20` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2440)
[Finished] [`06f28d20` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2470)
[Finished] [`06f28d20` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2437)
[Finished] [`06f28d20` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2461)
[Finished] [`7e248b10` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2439)
[Finished] [`7e248b10` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2469)
[Finished] [`7e248b10` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2436)
[Finished] [`7e248b10` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2460)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org