You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/09/09 17:18:48 UTC

Review Request 72853: RANGER-2991:Ranger should close solrclient connection

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72853/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-2991
    https://issues.apache.org/jira/browse/RANGER-2991


Repository: ranger


Description
-------

RANGER-2991:Ranger should close solrclient connection


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7631e5882 
  agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java dac006c6e 


Diff: https://reviews.apache.org/r/72853/diff/1/


Testing
-------

Verified in local VM.


Thanks,

Ramesh Mani


Re: Review Request 72853: RANGER-2991:Ranger should close solrclient connection

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72853/#review221834
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 9, 2020, 7:01 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72853/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2020, 7:01 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2991
>     https://issues.apache.org/jira/browse/RANGER-2991
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2991:Ranger should close solrclient connection
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7631e5882 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java dac006c6e 
> 
> 
> Diff: https://reviews.apache.org/r/72853/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in local VM.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 72853: RANGER-2991:Ranger should close solrclient connection

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72853/
-----------------------------------------------------------

(Updated Sept. 9, 2020, 7:01 p.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Fixed review comment


Bugs: RANGER-2991
    https://issues.apache.org/jira/browse/RANGER-2991


Repository: ranger


Description
-------

RANGER-2991:Ranger should close solrclient connection


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7631e5882 
  agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java dac006c6e 


Diff: https://reviews.apache.org/r/72853/diff/2/

Changes: https://reviews.apache.org/r/72853/diff/1-2/


Testing
-------

Verified in local VM.


Thanks,

Ramesh Mani


Re: Review Request 72853: RANGER-2991:Ranger should close solrclient connection

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72853/#review221832
-----------------------------------------------------------


Fix it, then Ship it!





agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Lines 101 (patched)
<https://reviews.apache.org/r/72853/#comment310914>

    Please review if solrClient should be set to null after calling close().


- Madhan Neethiraj


On Sept. 9, 2020, 5:18 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72853/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2020, 5:18 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2991
>     https://issues.apache.org/jira/browse/RANGER-2991
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2991:Ranger should close solrclient connection
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 7631e5882 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java dac006c6e 
> 
> 
> Diff: https://reviews.apache.org/r/72853/diff/1/
> 
> 
> Testing
> -------
> 
> Verified in local VM.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>