You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/02/14 10:24:12 UTC

[GitHub] carbondata pull request #1979: [CARBONDATA-2183]fix compaction when segment ...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1979

    [CARBONDATA-2183]fix compaction when segment is delete during compaction and remove unnecessary parameters in functions

    **Problem:**
    when compaction is started and job is running, and parallelly the segment involved in the compaction is deleted using DeleteSegmentByID, then compaction is success.
    
    **Solution:**
    when compaction is started and job is running, and parallelly the segment involved in the compaction is deleted using DeleteSegmentByID, then compaction should be aborted and failed. and proper error message should thrown to user. THis PR also removes the unnecessary parameters in functions.
    
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata compact_del

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1979.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1979
    
----
commit 500b4f01bd390a57c846de6d3309f143957248dd
Author: akashrn5 <ak...@...>
Date:   2018-02-14T10:15:04Z

    fix compaction when segment is delete during compaction and remove unnecessary parameters in functions

----


---

[GitHub] carbondata pull request #1979: [CARBONDATA-2183]fix compaction when segment ...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1979#discussion_r169886144
  
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala ---
    @@ -271,7 +271,7 @@ class CarbonTableCompactor(carbonLoadModel: CarbonLoadModel,
               false
           }
           operationContext.setProperty("commitComplete", commitComplete)
    -      if (!statusFileUpdation && !commitComplete) {
    +      if (!statusFileUpdation || !commitComplete) {
    --- End diff --
    
    Please add a test case to cover this scenario


---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2573/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2504/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    LGTM


---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3744/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3579/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1979
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3817/



---