You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/04/18 11:45:50 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1098: Allow to configure processor in Gremlin-JavaScript

spmallette commented on issue #1098: Allow to configure processor in Gremlin-JavaScript
URL: https://github.com/apache/tinkerpop/pull/1098#issuecomment-484470268
 
 
   Thanks for submitting this PR. In principle, allowing the setting of the `opProcessor` is fine by me 
   
   VOTE +1
   
   I'd like to wait for @jorgebay or @jbmusso to provide a more full review of the change itself before we merge. I assume that this change should target the `tp33` branch and it will need a CHANGELOG entry, but other than that it looks pretty straightforward.
   
   As a side note (not really related to the merge-ability of this PR), I think this represents more reason for bytecode to replace scripts. This sort of advanced configuration for both client and server is more than a user should have to do to get Cypher going with a TinkerPop implementation. It will be nice when we can push past scripts and into pure bytecode, but until then I guess this is what needs to be done. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services