You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Marcel Reutegger <mr...@adobe.com> on 2013/10/16 10:56:57 UTC

RE: svn commit: r1532681 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoDocumentStore.java

we should probably also consider upgrading the java driver. the
default write concern changed with 2.10.0:
http://docs.mongodb.org/manual/release-notes/drivers-write-concern/#driver-write-concern-change

the default is now equivalent to SAFE aka ACKNOWLEDGED.

regards
 marcel

> -----Original Message-----
> From: thomasm@apache.org [mailto:thomasm@apache.org]
> Sent: Mittwoch, 16. Oktober 2013 10:21
> To: oak-commits@jackrabbit.apache.org
> Subject: svn commit: r1532681 - /jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java
> 
> Author: thomasm
> Date: Wed Oct 16 08:21:14 2013
> New Revision: 1532681
> 
> URL: http://svn.apache.org/r1532681
> Log:
> OAK-1044: Reduce traffic between MongoMK and MongoDB - use
> WriteConcern.SAFE so that writeResult.getError() can be used
> 
> Modified:
>     jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java
> 
> Modified: jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java?rev=1532681&r1=1532680&r2=1532681&view=diff
> ==========================================================
> ====================
> --- jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java (original)
> +++ jackrabbit/oak/trunk/oak-
> core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoD
> ocumentStore.java Wed Oct 16 08:21:14 2013
> @@ -477,8 +477,7 @@ public class MongoDocumentStore implemen
>                  }
>              }
>              try {
> -
> -                WriteResult writeResult = dbCollection.updateMulti(query.get(),
> update);
> +                WriteResult writeResult = dbCollection.update(query.get(), update,
> false, true, WriteConcern.SAFE);
>                  if (writeResult.getError() != null) {
>                      throw new MicroKernelException("Update failed: " +
> writeResult.getError());
>                  }
>