You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2009/09/22 09:38:16 UTC

[jira] Created: (MAPREDUCE-1020) Add more unit tests to test the queue refresh feature MAPREDUCE-893

Add more unit tests to test the queue refresh feature MAPREDUCE-893
-------------------------------------------------------------------

                 Key: MAPREDUCE-1020
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1020
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: test
    Affects Versions: 0.21.0
            Reporter: Vinod K V
             Fix For: 0.21.0


MAPREDUCE-893 included unit tests verifying the sanity of the refresh feature - both the queue properities' refresh as well as the scheduler properties' refresh. The test suite can and should be expanded. This will help easily identifying issues that will otherwise be caught during manual testing. For e.g., during manual testing of MAPREDUCE-893, we identified an NPE in the scheduler iteration occuring during heartbeat, which could have been easily identified by unit tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1020) Add more unit tests to test the queue refresh feature MAPREDUCE-893

Posted by "V.V.Chaitanya Krishna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.V.Chaitanya Krishna updated MAPREDUCE-1020:
---------------------------------------------

    Attachment: MAPREDUCE-1020-1.patch

Uploading with the above test cases being implemented.
In addition, methods are introduced in JobInitializationPoller in order to access private inner class QueueInfo.maxUsersAllowedToInitialize and QueueInfo.maxJobsPerUserToInitialize.

> Add more unit tests to test the queue refresh feature MAPREDUCE-893
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1020
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1020
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Vinod K V
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1020-1.patch
>
>
> MAPREDUCE-893 included unit tests verifying the sanity of the refresh feature - both the queue properities' refresh as well as the scheduler properties' refresh. The test suite can and should be expanded. This will help easily identifying issues that will otherwise be caught during manual testing. For e.g., during manual testing of MAPREDUCE-893, we identified an NPE in the scheduler iteration occuring during heartbeat, which could have been easily identified by unit tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (MAPREDUCE-1020) Add more unit tests to test the queue refresh feature MAPREDUCE-893

Posted by "V.V.Chaitanya Krishna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.V.Chaitanya Krishna reassigned MAPREDUCE-1020:
------------------------------------------------

    Assignee: V.V.Chaitanya Krishna

> Add more unit tests to test the queue refresh feature MAPREDUCE-893
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1020
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1020
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Vinod K V
>            Assignee: V.V.Chaitanya Krishna
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1020-1.patch
>
>
> MAPREDUCE-893 included unit tests verifying the sanity of the refresh feature - both the queue properities' refresh as well as the scheduler properties' refresh. The test suite can and should be expanded. This will help easily identifying issues that will otherwise be caught during manual testing. For e.g., during manual testing of MAPREDUCE-893, we identified an NPE in the scheduler iteration occuring during heartbeat, which could have been easily identified by unit tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1020) Add more unit tests to test the queue refresh feature MAPREDUCE-893

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781862#action_12781862 ] 

Vinod K V commented on MAPREDUCE-1020:
--------------------------------------

Here are some of the pending tests that come to my mind:
 - verify that support for priorities cannot be changed from enabled to disabled and vice versa during refresh
 - verify the consistency in state of JobQueuesManager
    -- what happens to the 'jobQueues' list? (Not sure, myself)
    -- the actual lits of running and waiting jobs
 - JobInitializationPoller
  -- per-queue maxUsersAllowedToInitialize
  -- per-queue maxJobsPerUserToInitialize
  -- running-state of the poller
    -- jobs with the poller
    -- how changed ulimits affect the after-refresh behaviour of the poller
 - verify the running-state of the scheduler
    -- numJobsByUser
    -- numWaitingJobs
    -- maxCapacityPercent
    -- queue-scheduling-context objects
    -- map/reduce task-scheduling information
      -- cluster-capacity
      -- numRunningTasks
      -- numSlotsOccupied
      -- maxCapacity
      -- numSlotsOccupiedByUser

> Add more unit tests to test the queue refresh feature MAPREDUCE-893
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1020
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1020
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.21.0
>            Reporter: Vinod K V
>             Fix For: 0.21.0
>
>
> MAPREDUCE-893 included unit tests verifying the sanity of the refresh feature - both the queue properities' refresh as well as the scheduler properties' refresh. The test suite can and should be expanded. This will help easily identifying issues that will otherwise be caught during manual testing. For e.g., during manual testing of MAPREDUCE-893, we identified an NPE in the scheduler iteration occuring during heartbeat, which could have been easily identified by unit tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.