You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/30 19:20:49 UTC
[GitHub] [superset] kgabryje opened a new pull request #19446: feat(explore): Move chart actions into dropdown
kgabryje opened a new pull request #19446:
URL: https://github.com/apache/superset/pull/19446
### SUMMARY
This PR is a stage 1 of chart header redesign.
It focuses on moving the action button into a dropdown menu to declutter the header.
List of changes:
- move "download json/csv/image" buttons to "Download" submenu of actions dropdown
- move "Set up a report" to dropdown if there's no report
- move "Edit report", "Enable/disable report" and "Delete report" to "Manage the report" submenu of actions dropdown
- move embed code button and share by email button to dropdown
- move copy permalink button to the left side of the header, next to "favourite" button
- refactor embed code popover to be a modal, change styling of modal's content
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/15073128/160913924-c5a98c97-69fc-4c34-a8ed-ba75a3f26edf.mov
### TESTING INSTRUCTIONS
Verify that all action in the dropdown menu work exactly the same as they did before moving them to dropdown
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19446:
URL: https://github.com/apache/superset/pull/19446#discussion_r839516831
##########
File path: superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/index.jsx
##########
@@ -16,114 +16,430 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React from 'react';
-import { connect } from 'react-redux';
-import { bindActionCreators } from 'redux';
+import React, { useCallback, useState } from 'react';
+import { useDispatch, useSelector } from 'react-redux';
import PropTypes from 'prop-types';
-import { t } from '@superset-ui/core';
+import { FileOutlined, FileImageOutlined } from '@ant-design/icons';
+import { css, styled, t, useTheme } from '@superset-ui/core';
import { AntdDropdown } from 'src/components';
import { Menu } from 'src/components/Menu';
-import downloadAsImage from 'src/utils/downloadAsImage';
+import Icons from 'src/components/Icons';
import ModalTrigger from 'src/components/ModalTrigger';
-import { sliceUpdated } from 'src/explore/actions/exploreActions';
+import Button from 'src/components/Button';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import Checkbox from 'src/components/Checkbox';
+import { exportChart } from 'src/explore/exploreUtils';
+import downloadAsImage from 'src/utils/downloadAsImage';
+import { noOp } from 'src/utils/common';
+import { getChartPermalink } from 'src/utils/urlUtils';
+import { toggleActive } from 'src/reports/actions/reports';
import ViewQueryModal from '../controls/ViewQueryModal';
+import EmbedCodeContent from '../EmbedCodeContent';
+import { ExploreReport } from './ExploreReport';
+import copyTextToClipboard from '../../../utils/copy';
const propTypes = {
onOpenPropertiesModal: PropTypes.func,
onOpenInEditor: PropTypes.func,
- chartStatus: PropTypes.string,
latestQueryFormData: PropTypes.object.isRequired,
slice: PropTypes.object,
};
const MENU_KEYS = {
EDIT_PROPERTIES: 'edit_properties',
- RUN_IN_SQL_LAB: 'run_in_sql_lab',
+ DOWNLOAD_SUBMENU: 'download_submenu',
+ EXPORT_TO_CSV: 'export_to_csv',
+ EXPORT_TO_CSV_PIVOTED: 'export_to_csv_pivoted',
+ EXPORT_TO_JSON: 'export_to_json',
DOWNLOAD_AS_IMAGE: 'download_as_image',
+ SHARE_SUBMENU: 'share_submenu',
+ COPY_PERMALINK: 'copy_permalink',
+ EMBED_CODE: 'embed_code',
+ SHARE_BY_EMAIL: 'share_by_email',
+ REPORT_SUBMENU: 'report_submenu',
+ SET_UP_REPORT: 'set_up_report',
+ SET_REPORT_ACTIVE: 'set_report_active',
+ EDIT_REPORT: 'edit_report',
+ DELETE_REPORT: 'delete_report',
VIEW_QUERY: 'view_query',
+ RUN_IN_SQL_LAB: 'run_in_sql_lab',
};
-const ExploreAdditionalActionsMenu = props => {
- const { datasource } = props.latestQueryFormData;
+const VIZ_TYPES_PIVOTABLE = ['pivot_table', 'pivot_table_v2'];
+
+const MenuItemWithCheckboxContainer = styled.div`
+ ${({ theme }) => css`
+ display: flex;
+ align-items: center;
+
+ & svg {
+ width: ${theme.gridUnit * 3}px;
+ height: ${theme.gridUnit * 3}px;
+ }
+
+ & span[role='checkbox'] {
+ display: inline-flex;
+ margin-right: ${theme.gridUnit}px;
+ }
+ `}
+`;
+
+const MenuTrigger = styled(Button)`
+ ${({ theme }) => css`
+ width: ${theme.gridUnit * 6}px;
+ height: ${theme.gridUnit * 6}px;
+ padding: 0;
+ border: 1px solid ${theme.colors.primary.dark2};
+
+ &.ant-btn > span.anticon {
+ line-height: 0;
+ transition: inherit;
+ }
+
+ &:hover:not(:focus) > span.anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ `}
+`;
+
+const ExploreAdditionalActionsMenu = ({
+ latestQueryFormData,
+ canDownloadCSV,
+ addDangerToast,
+ addSuccessToast,
+ slice,
+ onOpenInEditor,
+ onOpenPropertiesModal,
+ canAddReports,
+}) => {
+ const theme = useTheme();
+ const [isDropdownVisible, setIsDropdownVisible] = useState(false);
+ const [openSubmenus, setOpenSubmenus] = useState([]);
+ const [showReportModal, setShowReportModal] = useState(false);
+ const [showDeleteReportModal, setShowDeleteReportModal] = useState(false);
+ const dispatch = useDispatch();
+ const report = useSelector(state => {
+ if (!state.reports) {
+ return undefined;
+ }
+ const reports = Object.values(state?.reports);
+ if (reports.length > 0) {
+ return reports[0];
+ }
+ return undefined;
+ });
+ const isReportActive = report?.active;
+ const { datasource } = latestQueryFormData;
const sqlSupported = datasource && datasource.split('__')[1] === 'table';
- const handleMenuClick = ({ key, domEvent }) => {
- const { slice, onOpenInEditor, latestQueryFormData } = props;
- switch (key) {
- case MENU_KEYS.EDIT_PROPERTIES:
- props.onOpenPropertiesModal();
- break;
- case MENU_KEYS.RUN_IN_SQL_LAB:
- onOpenInEditor(latestQueryFormData);
- break;
- case MENU_KEYS.DOWNLOAD_AS_IMAGE:
- downloadAsImage(
- '.panel-body > .chart-container',
- // eslint-disable-next-line camelcase
- slice?.slice_name ?? t('New chart'),
- {},
- true,
- )(domEvent);
- break;
- default:
- break;
+
+ const shareByEmail = useCallback(async () => {
+ try {
+ const subject = t('Superset Chart');
+ const url = await getChartPermalink(latestQueryFormData);
+ const body = encodeURIComponent(t('%s%s', 'Check out this chart: ', url));
+ window.location.href = `mailto:?Subject=${subject}%20&Body=${body}`;
+ } catch (error) {
+ addDangerToast(t('Sorry, something went wrong. Try again later.'));
}
- };
+ }, [addDangerToast, latestQueryFormData]);
+
+ const exportCSV = useCallback(
+ () =>
+ canDownloadCSV
+ ? exportChart({
+ formData: latestQueryFormData,
+ resultType: 'full',
+ resultFormat: 'csv',
+ })
+ : null,
+ [canDownloadCSV, latestQueryFormData],
+ );
+
+ const exportCSVPivoted = useCallback(
+ () =>
+ canDownloadCSV
+ ? exportChart({
+ formData: latestQueryFormData,
+ resultType: 'post_processed',
+ resultFormat: 'csv',
+ })
+ : null,
+ [canDownloadCSV, latestQueryFormData],
+ );
+
+ const exportJson = useCallback(
+ () =>
+ exportChart({
+ formData: latestQueryFormData,
+ resultType: 'results',
+ resultFormat: 'json',
+ }),
+ [latestQueryFormData],
+ );
+
+ const copyLink = useCallback(async () => {
+ try {
+ if (!latestQueryFormData) {
+ throw new Error();
+ }
+ const url = await getChartPermalink(latestQueryFormData);
+ await copyTextToClipboard(url);
+ addSuccessToast(t('Copied to clipboard!'));
+ } catch (error) {
+ addDangerToast(t('Sorry, something went wrong. Try again later.'));
+ }
+ }, [addDangerToast, addSuccessToast, latestQueryFormData]);
+
+ const handleMenuClick = useCallback(
+ ({ key, domEvent }) => {
+ switch (key) {
+ case MENU_KEYS.EDIT_PROPERTIES:
+ onOpenPropertiesModal();
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.EXPORT_TO_CSV:
+ exportCSV();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EXPORT_TO_CSV_PIVOTED:
+ exportCSVPivoted();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EXPORT_TO_JSON:
+ exportJson();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+
+ break;
+ case MENU_KEYS.DOWNLOAD_AS_IMAGE:
+ downloadAsImage(
+ '.panel-body > .chart-container',
+ // eslint-disable-next-line camelcase
+ slice?.slice_name ?? t('New chart'),
+ {},
+ true,
+ )(domEvent);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.COPY_PERMALINK:
+ copyLink();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EMBED_CODE:
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.SHARE_BY_EMAIL:
+ shareByEmail();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.SET_UP_REPORT:
+ setShowReportModal(true);
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.SET_REPORT_ACTIVE:
+ dispatch(toggleActive(report, !isReportActive));
+ break;
+ case MENU_KEYS.EDIT_REPORT:
+ setShowReportModal(true);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.DELETE_REPORT:
+ setShowDeleteReportModal(true);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.VIEW_QUERY:
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.RUN_IN_SQL_LAB:
+ onOpenInEditor(latestQueryFormData);
+ setIsDropdownVisible(false);
+ break;
+ default:
+ break;
+ }
+ },
+ [
+ copyLink,
+ dispatch,
+ exportCSV,
+ exportCSVPivoted,
+ exportJson,
+ isReportActive,
+ latestQueryFormData,
+ onOpenInEditor,
+ onOpenPropertiesModal,
+ report,
+ shareByEmail,
+ slice?.slice_name,
+ ],
+ );
- const { slice } = props;
return (
- <AntdDropdown
- trigger="click"
- data-test="query-dropdown"
- overlay={
- <Menu onClick={handleMenuClick} selectable={false}>
- {slice && (
- <Menu.Item key={MENU_KEYS.EDIT_PROPERTIES}>
- {t('Edit properties')}
- </Menu.Item>
- )}
- <Menu.Item key={MENU_KEYS.VIEW_QUERY}>
- <ModalTrigger
- triggerNode={
- <span data-test="view-query-menu-item">{t('View query')}</span>
- }
- modalTitle={t('View query')}
- modalBody={
- <ViewQueryModal
- latestQueryFormData={props.latestQueryFormData}
+ <>
+ <AntdDropdown
+ trigger="click"
+ data-test="query-dropdown"
+ visible={isDropdownVisible}
+ onVisibleChange={setIsDropdownVisible}
+ overlay={
+ <Menu
+ onClick={handleMenuClick}
+ selectable={false}
+ openKeys={openSubmenus}
+ onOpenChange={setOpenSubmenus}
+ >
+ {slice && (
+ <>
+ <Menu.Item key={MENU_KEYS.EDIT_PROPERTIES}>
+ {t('Edit chart properties')}
+ </Menu.Item>
+ <Menu.Divider />
+ </>
+ )}
+ <Menu.SubMenu
+ title={t('Download')}
+ key={MENU_KEYS.DOWNLOAD_SUBMENU}
+ >
+ {VIZ_TYPES_PIVOTABLE.includes(latestQueryFormData.viz_type) ? (
+ <>
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to original .CSV')}
+ </Menu.Item>
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV_PIVOTED}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to pivoted .CSV')}
+ </Menu.Item>
+ </>
+ ) : (
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to .CSV')}
+ </Menu.Item>
+ )}
+ <Menu.Item key={MENU_KEYS.EXPORT_TO_JSON} icon={<FileOutlined />}>
+ {t('Export to .JSON')}
+ </Menu.Item>
+ <Menu.Item
+ key={MENU_KEYS.DOWNLOAD_AS_IMAGE}
+ icon={<FileImageOutlined />}
+ >
+ {t('Download as image')}
+ </Menu.Item>
+ </Menu.SubMenu>
+ <Menu.SubMenu title={t('Share')} key={MENU_KEYS.SHARE_SUBMENU}>
+ <Menu.Item key={MENU_KEYS.COPY_PERMALINK}>
+ {t('Copy permalink to clipboard')}
+ </Menu.Item>
+ <Menu.Item key={MENU_KEYS.EMBED_CODE}>
+ <ModalTrigger
+ triggerNode={
+ <span data-test="embed-code-button">{t('Embed code')}</span>
Review comment:
π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19446:
URL: https://github.com/apache/superset/pull/19446#discussion_r839514798
##########
File path: superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/ExploreAdditionalActionsMenu.test.tsx
##########
@@ -18,11 +18,13 @@
*/
import React from 'react';
-import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import fetchMock from 'fetch-mock';
+import sinon from 'sinon';
import userEvent from '@testing-library/user-event';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
import * as chartAction from 'src/components/Chart/chartAction';
import * as downloadAsImage from 'src/utils/downloadAsImage';
-import fetchMock from 'fetch-mock';
+import * as exploreUtils from 'src/explore/exploreUtils';
Review comment:
I don't like that either, but I think that syntax is necessary to use `sinon.spy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52a3cba) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `60.26%`.
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64159 +67
Branches 6519 6525 +6
==========================================
+ Hits 42672 42731 +59
Misses 19729 19729
- Partials 1691 1699 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <60.26%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <ΓΈ> (+1.31%)` | :arrow_up: |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `57.14% <55.00%> (-38.32%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...52a3cba](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #19446:
URL: https://github.com/apache/superset/pull/19446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1084347318
It feels strange that the "Share chart by email" and "Embed code" are in the dropdown, while the permalink button is in the header, as I assume people will consider them similar use cases. I can see myself clicking on the action button and wondering where the permalink item is. Would one of these make sense?
1. Making a "Share chart" submenu where we would have "Copy permalink", "Embed code" and "Share chart by email". We could potentially leave the permalink button where it is, but this way all the sharing/permalink-based functionality could at least be found in the same place
2. Add "Copy permalink" to the Action menu. This would cause some duplication, but then it would also be located close to the other similar functionality
3. Move the permalink button into the Action menu all together. This would have the benefit of decluttering the header even further (I'm not sure how common it is to copy permalinks)
3. Turn the permalink button a dropdown menu with the different sharing options (copy permalink, share via email and embed code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74bafdf) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.03%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 74bafdf differs from pull request most recent head 740008d. Consider uploading reports for the commit 740008d to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.61% +0.03%
==========================================
Files 1675 1670 -5
Lines 64092 63950 -142
Branches 6519 6517 -2
==========================================
- Hits 42672 42603 -69
+ Misses 19729 19650 -79
- Partials 1691 1697 +6
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.41% <62.00%> (+0.15%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.37% <ΓΈ> (+0.45%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...rset-frontend/src/hooks/apiResources/dashboards.ts](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9kYXNoYm9hcmRzLnRz) | `33.33% <0.00%> (-3.04%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...740008d](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74bafdf) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.06%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 74bafdf differs from pull request most recent head 0f10e44. Consider uploading reports for the commit 0f10e44 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.55% 66.61% +0.06%
==========================================
Files 1675 1670 -5
Lines 64092 63950 -142
Branches 6519 6517 -2
==========================================
- Hits 42656 42603 -53
+ Misses 19745 19650 -95
- Partials 1691 1697 +6
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.41% <62.00%> (+0.15%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.37% <ΓΈ> (+0.45%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...rset-frontend/src/hooks/apiResources/dashboards.ts](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9kYXNoYm9hcmRzLnRz) | `33.33% <0.00%> (-3.04%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...0f10e44](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74bafdf) into [master](https://codecov.io/gh/apache/superset/commit/a8e7624eb5635ed9b84f1454d35029e1c18ebdee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7624) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.59% 66.61% +0.02%
==========================================
Files 1670 1670
Lines 63884 63950 +66
Branches 6510 6517 +7
==========================================
+ Hits 42542 42603 +61
+ Misses 19653 19650 -3
- Partials 1689 1697 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.41% <62.00%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.37% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a8e7624...74bafdf](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head 9636466. Consider uploading reports for the commit 9636466 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...9636466](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head c2ab524. Consider uploading reports for the commit c2ab524 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...c2ab524](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28d0c0f) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.00%`.
> The diff coverage is `60.26%`.
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
=======================================
Coverage 66.57% 66.58%
=======================================
Files 1675 1676 +1
Lines 64092 64172 +80
Branches 6519 6525 +6
=======================================
+ Hits 42672 42731 +59
- Misses 19729 19742 +13
- Partials 1691 1699 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.31% <60.26%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <ΓΈ> (+1.31%)` | :arrow_up: |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `57.14% <55.00%> (-38.32%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL0hlYXRtYXAuanM=) | `0.00% <0.00%> (ΓΈ)` | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...28d0c0f](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head 740008d. Consider uploading reports for the commit 740008d to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...740008d](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head ff8e3f1. Consider uploading reports for the commit ff8e3f1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...ff8e3f1](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74bafdf) into [master](https://codecov.io/gh/apache/superset/commit/a8e7624eb5635ed9b84f1454d35029e1c18ebdee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7624) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 74bafdf differs from pull request most recent head ec1d468. Consider uploading reports for the commit ec1d468 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.59% 66.61% +0.02%
==========================================
Files 1670 1670
Lines 63884 63950 +66
Branches 6510 6517 +7
==========================================
+ Hits 42542 42603 +61
+ Misses 19653 19650 -3
- Partials 1689 1697 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.41% <62.00%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.37% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a8e7624...ec1d468](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1084350317
> It feels strange that the "Share chart by email" and "Embed code" are in the dropdown, while the permalink button is in the header, as I assume people will consider them similar use cases. I can see myself clicking on the action button and wondering where the permalink item is. Would one of these make sense?
>
> 1. Making a "Share chart" submenu where we would have "Copy permalink", "Embed code" and "Share chart by email". We could potentially leave the permalink button where it is, but this way all the sharing/permalink-based functionality could at least be found in the same place
> 2. Add "Copy permalink" to the Action menu. This would cause some duplication, but then it would also be located close to the other similar functionality
> 3. Move the permalink button into the Action menu all together. This would have the benefit of decluttering the header even further (I'm not sure how common it is to copy permalinks)
> 4. Turn the permalink button a dropdown menu with the different sharing options (copy permalink, share via email and embed code)
Thanks for comments. Personally I like the 1st option the most, but I guess @kasiazjc would probably want to chime in π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #19446:
URL: https://github.com/apache/superset/pull/19446#discussion_r839468842
##########
File path: superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/ExploreAdditionalActionsMenu.test.tsx
##########
@@ -18,11 +18,13 @@
*/
import React from 'react';
-import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import fetchMock from 'fetch-mock';
+import sinon from 'sinon';
import userEvent from '@testing-library/user-event';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
import * as chartAction from 'src/components/Chart/chartAction';
import * as downloadAsImage from 'src/utils/downloadAsImage';
-import fetchMock from 'fetch-mock';
+import * as exploreUtils from 'src/explore/exploreUtils';
Review comment:
nit: importing `*` always makes me cringe, but in a test I guess it's acceptable π
##########
File path: superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/index.jsx
##########
@@ -16,114 +16,430 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React from 'react';
-import { connect } from 'react-redux';
-import { bindActionCreators } from 'redux';
+import React, { useCallback, useState } from 'react';
+import { useDispatch, useSelector } from 'react-redux';
import PropTypes from 'prop-types';
-import { t } from '@superset-ui/core';
+import { FileOutlined, FileImageOutlined } from '@ant-design/icons';
+import { css, styled, t, useTheme } from '@superset-ui/core';
import { AntdDropdown } from 'src/components';
import { Menu } from 'src/components/Menu';
-import downloadAsImage from 'src/utils/downloadAsImage';
+import Icons from 'src/components/Icons';
import ModalTrigger from 'src/components/ModalTrigger';
-import { sliceUpdated } from 'src/explore/actions/exploreActions';
+import Button from 'src/components/Button';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import Checkbox from 'src/components/Checkbox';
+import { exportChart } from 'src/explore/exploreUtils';
+import downloadAsImage from 'src/utils/downloadAsImage';
+import { noOp } from 'src/utils/common';
+import { getChartPermalink } from 'src/utils/urlUtils';
+import { toggleActive } from 'src/reports/actions/reports';
import ViewQueryModal from '../controls/ViewQueryModal';
+import EmbedCodeContent from '../EmbedCodeContent';
+import { ExploreReport } from './ExploreReport';
+import copyTextToClipboard from '../../../utils/copy';
const propTypes = {
onOpenPropertiesModal: PropTypes.func,
onOpenInEditor: PropTypes.func,
- chartStatus: PropTypes.string,
latestQueryFormData: PropTypes.object.isRequired,
slice: PropTypes.object,
};
const MENU_KEYS = {
EDIT_PROPERTIES: 'edit_properties',
- RUN_IN_SQL_LAB: 'run_in_sql_lab',
+ DOWNLOAD_SUBMENU: 'download_submenu',
+ EXPORT_TO_CSV: 'export_to_csv',
+ EXPORT_TO_CSV_PIVOTED: 'export_to_csv_pivoted',
+ EXPORT_TO_JSON: 'export_to_json',
DOWNLOAD_AS_IMAGE: 'download_as_image',
+ SHARE_SUBMENU: 'share_submenu',
+ COPY_PERMALINK: 'copy_permalink',
+ EMBED_CODE: 'embed_code',
+ SHARE_BY_EMAIL: 'share_by_email',
+ REPORT_SUBMENU: 'report_submenu',
+ SET_UP_REPORT: 'set_up_report',
+ SET_REPORT_ACTIVE: 'set_report_active',
+ EDIT_REPORT: 'edit_report',
+ DELETE_REPORT: 'delete_report',
VIEW_QUERY: 'view_query',
+ RUN_IN_SQL_LAB: 'run_in_sql_lab',
};
-const ExploreAdditionalActionsMenu = props => {
- const { datasource } = props.latestQueryFormData;
+const VIZ_TYPES_PIVOTABLE = ['pivot_table', 'pivot_table_v2'];
+
+const MenuItemWithCheckboxContainer = styled.div`
+ ${({ theme }) => css`
+ display: flex;
+ align-items: center;
+
+ & svg {
+ width: ${theme.gridUnit * 3}px;
+ height: ${theme.gridUnit * 3}px;
+ }
+
+ & span[role='checkbox'] {
+ display: inline-flex;
+ margin-right: ${theme.gridUnit}px;
+ }
+ `}
+`;
+
+const MenuTrigger = styled(Button)`
+ ${({ theme }) => css`
+ width: ${theme.gridUnit * 6}px;
+ height: ${theme.gridUnit * 6}px;
+ padding: 0;
+ border: 1px solid ${theme.colors.primary.dark2};
+
+ &.ant-btn > span.anticon {
+ line-height: 0;
+ transition: inherit;
+ }
+
+ &:hover:not(:focus) > span.anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ `}
+`;
+
+const ExploreAdditionalActionsMenu = ({
+ latestQueryFormData,
+ canDownloadCSV,
+ addDangerToast,
+ addSuccessToast,
+ slice,
+ onOpenInEditor,
+ onOpenPropertiesModal,
+ canAddReports,
+}) => {
+ const theme = useTheme();
+ const [isDropdownVisible, setIsDropdownVisible] = useState(false);
+ const [openSubmenus, setOpenSubmenus] = useState([]);
+ const [showReportModal, setShowReportModal] = useState(false);
+ const [showDeleteReportModal, setShowDeleteReportModal] = useState(false);
+ const dispatch = useDispatch();
+ const report = useSelector(state => {
+ if (!state.reports) {
+ return undefined;
+ }
+ const reports = Object.values(state?.reports);
+ if (reports.length > 0) {
+ return reports[0];
+ }
+ return undefined;
+ });
+ const isReportActive = report?.active;
+ const { datasource } = latestQueryFormData;
const sqlSupported = datasource && datasource.split('__')[1] === 'table';
- const handleMenuClick = ({ key, domEvent }) => {
- const { slice, onOpenInEditor, latestQueryFormData } = props;
- switch (key) {
- case MENU_KEYS.EDIT_PROPERTIES:
- props.onOpenPropertiesModal();
- break;
- case MENU_KEYS.RUN_IN_SQL_LAB:
- onOpenInEditor(latestQueryFormData);
- break;
- case MENU_KEYS.DOWNLOAD_AS_IMAGE:
- downloadAsImage(
- '.panel-body > .chart-container',
- // eslint-disable-next-line camelcase
- slice?.slice_name ?? t('New chart'),
- {},
- true,
- )(domEvent);
- break;
- default:
- break;
+
+ const shareByEmail = useCallback(async () => {
+ try {
+ const subject = t('Superset Chart');
+ const url = await getChartPermalink(latestQueryFormData);
+ const body = encodeURIComponent(t('%s%s', 'Check out this chart: ', url));
+ window.location.href = `mailto:?Subject=${subject}%20&Body=${body}`;
+ } catch (error) {
+ addDangerToast(t('Sorry, something went wrong. Try again later.'));
}
- };
+ }, [addDangerToast, latestQueryFormData]);
+
+ const exportCSV = useCallback(
+ () =>
+ canDownloadCSV
+ ? exportChart({
+ formData: latestQueryFormData,
+ resultType: 'full',
+ resultFormat: 'csv',
+ })
+ : null,
+ [canDownloadCSV, latestQueryFormData],
+ );
+
+ const exportCSVPivoted = useCallback(
+ () =>
+ canDownloadCSV
+ ? exportChart({
+ formData: latestQueryFormData,
+ resultType: 'post_processed',
+ resultFormat: 'csv',
+ })
+ : null,
+ [canDownloadCSV, latestQueryFormData],
+ );
+
+ const exportJson = useCallback(
+ () =>
+ exportChart({
+ formData: latestQueryFormData,
+ resultType: 'results',
+ resultFormat: 'json',
+ }),
+ [latestQueryFormData],
+ );
+
+ const copyLink = useCallback(async () => {
+ try {
+ if (!latestQueryFormData) {
+ throw new Error();
+ }
+ const url = await getChartPermalink(latestQueryFormData);
+ await copyTextToClipboard(url);
+ addSuccessToast(t('Copied to clipboard!'));
+ } catch (error) {
+ addDangerToast(t('Sorry, something went wrong. Try again later.'));
+ }
+ }, [addDangerToast, addSuccessToast, latestQueryFormData]);
+
+ const handleMenuClick = useCallback(
+ ({ key, domEvent }) => {
+ switch (key) {
+ case MENU_KEYS.EDIT_PROPERTIES:
+ onOpenPropertiesModal();
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.EXPORT_TO_CSV:
+ exportCSV();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EXPORT_TO_CSV_PIVOTED:
+ exportCSVPivoted();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EXPORT_TO_JSON:
+ exportJson();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+
+ break;
+ case MENU_KEYS.DOWNLOAD_AS_IMAGE:
+ downloadAsImage(
+ '.panel-body > .chart-container',
+ // eslint-disable-next-line camelcase
+ slice?.slice_name ?? t('New chart'),
+ {},
+ true,
+ )(domEvent);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.COPY_PERMALINK:
+ copyLink();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.EMBED_CODE:
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.SHARE_BY_EMAIL:
+ shareByEmail();
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.SET_UP_REPORT:
+ setShowReportModal(true);
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.SET_REPORT_ACTIVE:
+ dispatch(toggleActive(report, !isReportActive));
+ break;
+ case MENU_KEYS.EDIT_REPORT:
+ setShowReportModal(true);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.DELETE_REPORT:
+ setShowDeleteReportModal(true);
+ setIsDropdownVisible(false);
+ setOpenSubmenus([]);
+ break;
+ case MENU_KEYS.VIEW_QUERY:
+ setIsDropdownVisible(false);
+ break;
+ case MENU_KEYS.RUN_IN_SQL_LAB:
+ onOpenInEditor(latestQueryFormData);
+ setIsDropdownVisible(false);
+ break;
+ default:
+ break;
+ }
+ },
+ [
+ copyLink,
+ dispatch,
+ exportCSV,
+ exportCSVPivoted,
+ exportJson,
+ isReportActive,
+ latestQueryFormData,
+ onOpenInEditor,
+ onOpenPropertiesModal,
+ report,
+ shareByEmail,
+ slice?.slice_name,
+ ],
+ );
- const { slice } = props;
return (
- <AntdDropdown
- trigger="click"
- data-test="query-dropdown"
- overlay={
- <Menu onClick={handleMenuClick} selectable={false}>
- {slice && (
- <Menu.Item key={MENU_KEYS.EDIT_PROPERTIES}>
- {t('Edit properties')}
- </Menu.Item>
- )}
- <Menu.Item key={MENU_KEYS.VIEW_QUERY}>
- <ModalTrigger
- triggerNode={
- <span data-test="view-query-menu-item">{t('View query')}</span>
- }
- modalTitle={t('View query')}
- modalBody={
- <ViewQueryModal
- latestQueryFormData={props.latestQueryFormData}
+ <>
+ <AntdDropdown
+ trigger="click"
+ data-test="query-dropdown"
+ visible={isDropdownVisible}
+ onVisibleChange={setIsDropdownVisible}
+ overlay={
+ <Menu
+ onClick={handleMenuClick}
+ selectable={false}
+ openKeys={openSubmenus}
+ onOpenChange={setOpenSubmenus}
+ >
+ {slice && (
+ <>
+ <Menu.Item key={MENU_KEYS.EDIT_PROPERTIES}>
+ {t('Edit chart properties')}
+ </Menu.Item>
+ <Menu.Divider />
+ </>
+ )}
+ <Menu.SubMenu
+ title={t('Download')}
+ key={MENU_KEYS.DOWNLOAD_SUBMENU}
+ >
+ {VIZ_TYPES_PIVOTABLE.includes(latestQueryFormData.viz_type) ? (
+ <>
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to original .CSV')}
+ </Menu.Item>
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV_PIVOTED}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to pivoted .CSV')}
+ </Menu.Item>
+ </>
+ ) : (
+ <Menu.Item
+ key={MENU_KEYS.EXPORT_TO_CSV}
+ icon={<FileOutlined />}
+ disabled={!canDownloadCSV}
+ >
+ {t('Export to .CSV')}
+ </Menu.Item>
+ )}
+ <Menu.Item key={MENU_KEYS.EXPORT_TO_JSON} icon={<FileOutlined />}>
+ {t('Export to .JSON')}
+ </Menu.Item>
+ <Menu.Item
+ key={MENU_KEYS.DOWNLOAD_AS_IMAGE}
+ icon={<FileImageOutlined />}
+ >
+ {t('Download as image')}
+ </Menu.Item>
+ </Menu.SubMenu>
+ <Menu.SubMenu title={t('Share')} key={MENU_KEYS.SHARE_SUBMENU}>
+ <Menu.Item key={MENU_KEYS.COPY_PERMALINK}>
+ {t('Copy permalink to clipboard')}
+ </Menu.Item>
+ <Menu.Item key={MENU_KEYS.EMBED_CODE}>
+ <ModalTrigger
+ triggerNode={
+ <span data-test="embed-code-button">{t('Embed code')}</span>
Review comment:
minor comment: I'd kinda prefer to see "Embed code" below "Share chart via email"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1084361382
> > It feels strange that the "Share chart by email" and "Embed code" are in the dropdown, while the permalink button is in the header, as I assume people will consider them similar use cases. I can see myself clicking on the action button and wondering where the permalink item is. Would one of these make sense?
> >
> > 1. Making a "Share chart" submenu where we would have "Copy permalink", "Embed code" and "Share chart by email". We could potentially leave the permalink button where it is, but this way all the sharing/permalink-based functionality could at least be found in the same place
> > 2. Add "Copy permalink" to the Action menu. This would cause some duplication, but then it would also be located close to the other similar functionality
> > 3. Move the permalink button into the Action menu all together. This would have the benefit of decluttering the header even further (I'm not sure how common it is to copy permalinks)
> > 4. Turn the permalink button a dropdown menu with the different sharing options (copy permalink, share via email and embed code)
>
> Thanks for comments. Personally I like the 1st option the most, but I guess @kasiazjc would probably want to chime in π
Good point @villebro! I agree, 1st option would work best. In that case we can remove the icon from the header So we don't duplicate the actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52a3cba) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `60.26%`.
> :exclamation: Current head 52a3cba differs from pull request most recent head 4cf45b1. Consider uploading reports for the commit 4cf45b1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64159 +67
Branches 6519 6525 +6
==========================================
+ Hits 42672 42731 +59
Misses 19729 19729
- Partials 1691 1699 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <60.26%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <ΓΈ> (+1.31%)` | :arrow_up: |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `57.14% <55.00%> (-38.32%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...4cf45b1](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1084379323
@kasiazjc @villebro Thanks for feedback, here's how it looks after moving copy permalink to menu π
<img width="1180" alt="image" src="https://user-images.githubusercontent.com/15073128/161032925-e598af05-528c-4647-b3d9-967b0cd7c6fa.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head 52a3cba. Consider uploading reports for the commit 52a3cba to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...52a3cba](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f10e44) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `62.00%`.
> :exclamation: Current head 0f10e44 differs from pull request most recent head 80f0eb0. Consider uploading reports for the commit 80f0eb0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64158 +66
Branches 6519 6526 +7
==========================================
+ Hits 42672 42730 +58
+ Misses 19729 19727 -2
- Partials 1691 1701 +10
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.32% <62.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `45.67% <23.07%> (-3.01%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `64.83% <62.79%> (-30.62%)` | :arrow_down: |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `63.04% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...80f0eb0](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19446: feat(explore): Move chart actions into dropdown
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1083575985
# [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19446](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52a3cba) into [master](https://codecov.io/gh/apache/superset/commit/6b136c2bc9a6c9756e5319b045e3c42da06243cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b136c2) will **increase** coverage by `0.02%`.
> The diff coverage is `60.26%`.
> :exclamation: Current head 52a3cba differs from pull request most recent head 28d0c0f. Consider uploading reports for the commit 28d0c0f to get more accurate results
```diff
@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
+ Coverage 66.57% 66.60% +0.02%
==========================================
Files 1675 1675
Lines 64092 64159 +67
Branches 6519 6525 +6
==========================================
+ Hits 42672 42731 +59
Misses 19729 19729
- Partials 1691 1699 +8
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.33% <60.26%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <ΓΈ> (ΓΈ)` | |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `50.00% <ΓΈ> (+1.31%)` | :arrow_up: |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `57.14% <55.00%> (-38.32%)` | :arrow_down: |
| [...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L0V4cGxvcmVSZXBvcnQudHN4) | `57.89% <57.89%> (ΓΈ)` | |
| [...ontend/src/explore/components/EmbedCodeContent.jsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVDb250ZW50LmpzeA==) | `76.66% <76.66%> (ΓΈ)` | |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `78.46% <100.00%> (-3.63%)` | :arrow_down: |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b136c2...28d0c0f](https://codecov.io/gh/apache/superset/pull/19446?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org