You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/11/06 21:36:36 UTC
[GitHub] reddycharan commented on issue #1789: Cache InetSocketAddress if
hostname is IPAddress
reddycharan commented on issue #1789: Cache InetSocketAddress if hostname is IPAddress
URL: https://github.com/apache/bookkeeper/pull/1789#issuecomment-436417292
@merlimat we cannt use InetSocketAddress.createUnresolved() here, because InetSocketAddress.getAddress would return null if it is unresolved https://docs.oracle.com/javase/7/docs/api/java/net/InetSocketAddress.html#getAddress()
in many places in our code we would use address of InetSocketAddress -
https://github.com/apache/bookkeeper/blob/318893399b8040a7d291b8094f0d218a3b4e4f1e/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java#L578
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/CommandHelpers.java#L44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services