You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Pavel Rebriy (JIRA)" <ji...@apache.org> on 2008/07/23 14:25:32 UTC

[jira] Created: (THRIFT-95) TBufferedTransport class initializtion error

TBufferedTransport class initializtion error
--------------------------------------------

                 Key: THRIFT-95
                 URL: https://issues.apache.org/jira/browse/THRIFT-95
             Project: Thrift
          Issue Type: Bug
          Components: Library (C++)
            Reporter: Pavel Rebriy
         Attachments: THRIFT-95.patch

Incorrect initialization of TBufferedTransport class in constructor:

TBufferedTransport(boost::shared_ptr<TTransport> transport, uint32_t rsz, uint32_t wsz)

Class member wBufSize_ is initializing by rsz parameter.

Bug was found with -Wall option :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-95) TBufferedTransport class initializtion error

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-95.
-------------------------------

    Resolution: Fixed

Strange that this didn't trigger a warning for me.  What system are you on, and what gcc version are you using?

> TBufferedTransport class initializtion error
> --------------------------------------------
>
>                 Key: THRIFT-95
>                 URL: https://issues.apache.org/jira/browse/THRIFT-95
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Pavel Rebriy
>         Attachments: THRIFT-95.patch
>
>
> Incorrect initialization of TBufferedTransport class in constructor:
> TBufferedTransport(boost::shared_ptr<TTransport> transport, uint32_t rsz, uint32_t wsz)
> Class member wBufSize_ is initializing by rsz parameter.
> Bug was found with -Wall option :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-95) TBufferedTransport class initializtion error

Posted by "Pavel Rebriy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616774#action_12616774 ] 

Pavel Rebriy commented on THRIFT-95:
------------------------------------

I'm working with gcc version 3.4.6 on FreeBSD release 6.3.


> TBufferedTransport class initializtion error
> --------------------------------------------
>
>                 Key: THRIFT-95
>                 URL: https://issues.apache.org/jira/browse/THRIFT-95
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Pavel Rebriy
>         Attachments: THRIFT-95.patch
>
>
> Incorrect initialization of TBufferedTransport class in constructor:
> TBufferedTransport(boost::shared_ptr<TTransport> transport, uint32_t rsz, uint32_t wsz)
> Class member wBufSize_ is initializing by rsz parameter.
> Bug was found with -Wall option :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-95) TBufferedTransport class initializtion error

Posted by "Pavel Rebriy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Rebriy updated THRIFT-95:
-------------------------------

    Attachment: THRIFT-95.patch

Patch to fix the problem.

> TBufferedTransport class initializtion error
> --------------------------------------------
>
>                 Key: THRIFT-95
>                 URL: https://issues.apache.org/jira/browse/THRIFT-95
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Pavel Rebriy
>         Attachments: THRIFT-95.patch
>
>
> Incorrect initialization of TBufferedTransport class in constructor:
> TBufferedTransport(boost::shared_ptr<TTransport> transport, uint32_t rsz, uint32_t wsz)
> Class member wBufSize_ is initializing by rsz parameter.
> Bug was found with -Wall option :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.